Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: align update EM pipeline request to new specs #285

Merged
merged 1 commit into from
Oct 25, 2024
Merged

Conversation

CanobbioE
Copy link
Contributor

@CanobbioE CanobbioE commented Oct 25, 2024

ENG-5051

Checklist

  • make test passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

Affected core subsystem(s)

Description of change

Fix for bug https://indykite.atlassian.net/browse/ENG-5051 broke the sdk tests

@CanobbioE CanobbioE requested a review from a team as a code owner October 25, 2024 17:19
@CanobbioE CanobbioE requested a review from maaland October 25, 2024 17:19
Copy link

codecov bot commented Oct 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.30%. Comparing base (ed814a4) to head (27574e9).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #285   +/-   ##
=======================================
  Coverage   72.30%   72.30%           
=======================================
  Files          39       39           
  Lines        2011     2011           
=======================================
  Hits         1454     1454           
  Misses        493      493           
  Partials       64       64           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

deepsource-io bot commented Oct 25, 2024

Here's the code health analysis summary for commits ed814a4..27574e9. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource Go LogoGo✅ SuccessView Check ↗

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

@cowan-macady
Copy link
Contributor

It is a lot of breaking changes.
Are you sure nobody is using EM ?

@cowan-macady cowan-macady merged commit 05e99c5 into master Oct 25, 2024
11 checks passed
@cowan-macady cowan-macady deleted the ENG-5051 branch October 25, 2024 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants