fix: align update EM pipeline request to new specs

ENG-5051
indykite · Oct 25, 2024 · 27574e9 · 27574e9
1 parent ed814a4
commit 27574e9
Show file tree

Hide file tree

Showing 4 changed files with 1 addition and 17 deletions.
diff --git a/config/config_integration_test.go b/config/config_integration_test.go
@@ -282,7 +282,7 @@ var _ = Describe("Configuration", func() {
 
 			// update config node
 			configurationUpd := &configpb.EntityMatchingPipelineConfig{
-				NodeFilter: integration.NodeFilter2,
+				SimilarityScoreCutoff: 0.9,
 			}
 			updateReq, _ := config.NewUpdate(configID)
 			updateReq.WithDisplayName("EntityMatching2" + timeNow)

diff --git a/config/config_node_test.go b/config/config_node_test.go
@@ -1118,10 +1118,6 @@ var _ = Describe("ConfigNode", func() {
 		It("UpdateEntityMatchingPipelineConfig", func() {
 			now := timestamppb.New(time.Now())
 			configuration := &configpb.EntityMatchingPipelineConfig{
-				NodeFilter: &configpb.EntityMatchingPipelineConfig_NodeFilter{
-					SourceNodeTypes: []string{"employee"},
-					TargetNodeTypes: []string{"user"},
-				},
 				SimilarityScoreCutoff: 0.9,
 				PropertyMappingStatus: configpb.EntityMatchingPipelineConfig_STATUS_SUCCESS,
 				EntityMatchingStatus:  configpb.EntityMatchingPipelineConfig_STATUS_PENDING,
@@ -1161,10 +1157,6 @@ var _ = Describe("ConfigNode", func() {
 					"Config": PointTo(MatchFields(IgnoreExtras, Fields{
 						"EntityMatchingPipelineConfig": test.EqualProto(
 							&configpb.EntityMatchingPipelineConfig{
-								NodeFilter: &configpb.EntityMatchingPipelineConfig_NodeFilter{
-									SourceNodeTypes: []string{"employee"},
-									TargetNodeTypes: []string{"user"},
-								},
 								SimilarityScoreCutoff: 0.9,
 								PropertyMappingStatus: configpb.EntityMatchingPipelineConfig_STATUS_SUCCESS,
 								EntityMatchingStatus:  configpb.EntityMatchingPipelineConfig_STATUS_PENDING,

diff --git a/examples/config/cmd/entity_matching_pipeline.go b/examples/config/cmd/entity_matching_pipeline.go
@@ -84,10 +84,6 @@ var updateEntityMatchingPipelineConfigCmd = &cobra.Command{
 	Short: "Update EntityMatchingPipeline config",
 	Run: func(cmd *cobra.Command, args []string) {
 		configuration := &configpb.EntityMatchingPipelineConfig{
-			NodeFilter: &configpb.EntityMatchingPipelineConfig_NodeFilter{
-				SourceNodeTypes: []string{"employee"},
-				TargetNodeTypes: []string{"user"},
-			},
 			SimilarityScoreCutoff: 0.9,
 			PropertyMappingStatus: configpb.EntityMatchingPipelineConfig_STATUS_SUCCESS,
 			EntityMatchingStatus:  configpb.EntityMatchingPipelineConfig_STATUS_PENDING,

diff --git a/test/constants.go b/test/constants.go
@@ -219,10 +219,6 @@ var (
 		SourceNodeTypes: []string{"Customer"},
 		TargetNodeTypes: []string{"Client"},
 	}
-	NodeFilter2 = &configpb.EntityMatchingPipelineConfig_NodeFilter{
-		SourceNodeTypes: []string{"Employee"},
-		TargetNodeTypes: []string{"User"},
-	}
 	NodeFilter3 = &configpb.EntityMatchingPipelineConfig_NodeFilter{
 		SourceNodeTypes: []string{"Employee"},
 	}