Direct Solver: Recursive Skeletonization #164
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexfikl
force-pushed
the
direct-solver-recursion
branch
5 times, most recently
from
39e8347 to
80bb8e1
Compare
alexfikl
force-pushed
the
direct-solver-recursion
branch
3 times, most recently
from
8e3731d to
78699ec
Compare
|
@inducer This should be ready for a look. It doesn't do much:
|
alexfikl
force-pushed
the
direct-solver-recursion
branch
3 times, most recently
from
7ed33f4 to
ea42c82
Compare
alexfikl
force-pushed
the
direct-solver-recursion
branch
5 times, most recently
from
80fe1fb to
b44f4a8
Compare
alexfikl
force-pushed
the
direct-solver-recursion
branch
2 times, most recently
from
cc4be24 to
0176d32
Compare
alexfikl
force-pushed
the
direct-solver-recursion
branch
from
0176d32 to
f71a21b
Compare
inducer
reviewed
Aug 23, 2022
pytential/linalg/cluster.py
Outdated
|
|
||
| Current level that is represented. | ||
|
|
||
| .. attribute:: nlevels |
There was a problem hiding this comment.
Reworked this a while back, so not quite sure if your comment still applies?
pytential/linalg/cluster.py
Outdated
| # {{{ cluster tree | ||
|
|
||
| @dataclass(frozen=True) | ||
| class ClusterTreeLevel: |
There was a problem hiding this comment.
Is this two things rather than one?
There was a problem hiding this comment.
Yeah, separated into a ClusterTree and ClusterLevel with a ClusterTree.levels() iterator to go through them for the recursive skeletonization.
Naming could still be better probably?
| @@ -355,7 +360,25 @@ def test_skeletonize_by_proxy(actx_factory, case, visualize=False): | |||
| case = replace(case, approx_cluster_count=6, id_eps=1.0e-8) | |||
| logger.info("\n%s", case) | |||
|
|
|||
| run_skeletonize_by_proxy(actx, case, case.resolutions[0], visualize=visualize) | |||
| dd = sym.DOFDescriptor(case.name, discr_stage=case.skel_discr_stage) | |||
There was a problem hiding this comment.
Update the test docstring to describe precisely what's being tested here.
There was a problem hiding this comment.
Updated the blurb in
https://github.com/inducer/pytential/compare/f71a21b1a54791b02b35712225b9cfaca4be60cf..9a8db7ff410051a6b7d86cd8d5b934d02d094fef
Let me know if it's clear enough!
alexfikl
force-pushed
the
direct-solver-recursion
branch
2 times, most recently
from
9a8db7f to
ce00d4e
Compare
alexfikl
force-pushed
the
direct-solver-recursion
branch
3 times, most recently
from
c1e986c to
814b8ac
Compare
alexfikl
force-pushed
the
direct-solver-recursion
branch
from
63fcc25 to
17890c4
Compare
alexfikl
force-pushed
the
direct-solver-recursion
branch
2 times, most recently
from
845f75d to
b17e975
Compare
|
Hm, weird that this failed and #174 seems to be doing just fine. They did get different machines:
EDIT: Latest runs (after #212) seem to pass repeatedly again, e.g.
|
alexfikl
force-pushed
the
direct-solver-recursion
branch
from
b17e975 to
53a0212
Compare
alexfikl
force-pushed
the
direct-solver-recursion
branch
3 times, most recently
from
9630b4f to
32ecc58
Compare
alexfikl
force-pushed
the
direct-solver-recursion
branch
2 times, most recently
from
f79175f to
19f4098
Compare
alexfikl
force-pushed
the
direct-solver-recursion
branch
from
19f4098 to
e9643cc
Compare
inducer
reviewed
Oct 20, 2023
|
|
||
|
|
||
| def make_cluster_parent_map(parent_ids: np.ndarray) -> np.ndarray: | ||
| """Construct a parent map for :attr:`ClusterLevel.parent_map`.""" |
There was a problem hiding this comment.
Rephrase/rework? "All children in a bucket"?
There was a problem hiding this comment.
Rephrased and added some more context in https://github.com/inducer/pytential/compare/e9643cc480e53575274e4dc8e14d81d9b060f6b6..20fbc31a57c1a9a642abfa0a9b7a83ad81f1a1d5. Thoughts?
alexfikl
force-pushed
the
direct-solver-recursion
branch
from
e9643cc to
20fbc31
Compare
|
@inducer I think inducer/ci-support@1475971 broke pylint (it's not finding the cython stuff anymore?). Any suggestion for a fix? |
alexfikl
force-pushed
the
direct-solver-recursion
branch
from
20fbc31 to
6983a42
Compare
alexfikl
force-pushed
the
direct-solver-recursion
branch
from
6983a42 to
ab228e6
Compare
alexfikl
force-pushed
the
direct-solver-recursion
branch
from
ab228e6 to
c92b7f0
Compare
alexfikl
force-pushed
the
direct-solver-recursion
branch
2 times, most recently
from
f6e7c6e to
78eebbf
Compare
alexfikl
force-pushed
the
direct-solver-recursion
branch
2 times, most recently
from
c479984 to
8aa200f
Compare
alexfikl
force-pushed
the
direct-solver-recursion
branch
3 times, most recently
from
9c5bb68 to
a7c5d19
Compare
alexfikl
force-pushed
the
direct-solver-recursion
branch
2 times, most recently
from
8bef46c to
ae443aa
Compare
alexfikl
force-pushed
the
direct-solver-recursion
branch
from
ae443aa to
85033db
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempting to break up the direct solver MR into smaller, more reviewable pieces. As a rundown
linalg.proxy).The code for this is mostly in the deprecated https://gitlab.tiker.net/inducer/pytential/-/merge_requests/137.