Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Service transparency and usability: expected data keys, supported representations, unit tests #817

Merged
merged 42 commits into from
Oct 1, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
42 commits
Select commit Hold shift + click to select a range
04e0780
preliminary implementation of stage attribute which contains keys exp…
thehrh Aug 15, 2024
0de718b
fix ContainerSet constructor and declare expected keys in a couple of…
thehrh Aug 15, 2024
5ad3121
Add expected container params to more stages
Aug 16, 2024
c7a5473
skeleton service testing script (detection, importing)
thehrh Aug 16, 2024
928e2ef
And more stages with exp keys
Aug 16, 2024
2ba3bf6
Even more stages with exp keys
Aug 19, 2024
3c33a77
First version of service test
Aug 20, 2024
77b4688
minorminor changes and more modularity for test_services; adapt aeff.…
thehrh Aug 21, 2024
8ca3e7f
default keyword args to each Param
thehrh Aug 21, 2024
92b7d18
mostly more tests; also now raise error when a service doesn't specif…
thehrh Aug 21, 2024
0f74849
Merge branch 'master' into stage_declare_expected_keys
thehrh Aug 21, 2024
9351d29
get more tests to run (or at least reduce remaining testing work for …
thehrh Aug 21, 2024
fb22e2d
improve service testing logic (check for init. object type, less stup…
thehrh Aug 22, 2024
cd330eb
toy_event_generator has no exp. cont. keys, missing append to failed …
thehrh Aug 22, 2024
97cec37
Also test some stages in hist mode
Aug 22, 2024
d9ccf55
Handle aux and multi dim container key
Aug 22, 2024
c5a491d
respect PISA data types when filling containers, rename test containe…
thehrh Aug 22, 2024
8d41dfc
fix reco.simple_param and use tables from fridge to init. three flux …
thehrh Aug 23, 2024
878d860
Add supported modes to stage
Aug 23, 2024
4c79bee
Rename to supported reps and add example
Aug 23, 2024
e7ef03d
be more clever w.r.t. automatically (re)running stage setup (introduc…
thehrh Aug 24, 2024
32a9359
revert default value of standalone mode-flag, turn representation che…
thehrh Aug 24, 2024
5ab4f26
more flexibility in testing calc and apply modes, implement supported…
thehrh Aug 24, 2024
8ca11da
delineate service testing script's output and add to workflow; remove…
thehrh Aug 26, 2024
f95df79
on-the fly generation of scale_file for utils.adhoc_sys
thehrh Aug 26, 2024
01d6c7f
get tests to pass for flux.barr_simple and data.simple_signal
thehrh Aug 26, 2024
a37b279
prepare for special treatment as required e.g. by osc.external but sk…
thehrh Aug 26, 2024
6015551
let discr_sys.ultrasurfaces init example also use toy input file
thehrh Aug 26, 2024
6597050
test with toy input file for data.meows_loader and rename output_name…
thehrh Aug 26, 2024
105dc24
Remove freedom data loader (should use standard data loader in the fu…
Aug 27, 2024
8683499
adapt file modes for test scripts and make service testing successful…
thehrh Aug 27, 2024
4574732
Merge branch 'stage_declare_expected_keys' of https://github.com/theh…
Aug 27, 2024
22814cc
Test for sqlite_loader
Aug 27, 2024
a50eef2
Ignore flux.airs
Aug 27, 2024
17ba2fa
more informative test logging output and switch to fp64 in workflow
thehrh Aug 27, 2024
76263cb
Add pisa resources path to workflow
JanWeldert Aug 28, 2024
60330d8
Add MCEq example and HG dummy
JanWeldert Aug 29, 2024
3feea5a
Merge branch 'stage_declare_expected_keys' of https://github.com/theh…
JanWeldert Aug 29, 2024
9fabe3f
start draft on service how-to based on stages/README.md and pisa3 wiki
thehrh Sep 11, 2024
d7e231e
service howto draft done
thehrh Sep 16, 2024
8496f00
merge origin/master and fix conflicts in stage.py
thehrh Sep 19, 2024
217df0c
small documentation fixes and touchups
thehrh Sep 19, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .github/workflows/pythonpackage.yml
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,9 @@ jobs:
run: |
pip install pytest
PISA_FTYPE=fp32 PISA_TARGET=cpu MPLBACKEND=agg ./pisa_tests/test_example_pipelines.py -v
- name: Test PISA services, double precision
run: |
PISA_FTYPE=fp64 PISA_TARGET=cpu PISA_RESOURCES=./pisa_examples/resources MPLBACKEND=agg ./pisa_tests/test_services.py -v
- name: Test PISA imports and unit tests, double precision
run: |
pip install pytest
Expand Down
2 changes: 1 addition & 1 deletion pisa/core/bin_indexing.py
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,7 @@ def lookup_indices(sample, binning):
if len(sample) != binning.num_dims:
raise ValueError(
f"`binning` has {binning.num_dims} dimension(s), but `sample`"
f"contains {len(sample)} arrays (so represents {len(sample)}"
f" contains {len(sample)} arrays (so represents {len(sample)}"
f" dimensions)"
)

Expand Down
Loading
Loading