Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Service transparency and usability: expected data keys, supported representations, unit tests #817

Merged
merged 42 commits into from
Oct 1, 2024

Conversation

thehrh
Copy link
Contributor

@thehrh thehrh commented Aug 27, 2024

thehrh and others added 30 commits August 15, 2024 21:07
…ected to be present in all containers and some necessary logic in container.py; also modify some services from example configs accordingly
… services (with case distinction in utils.hist)
…param filepaths so they are always found by find_resource
…each service) and improve test script summary output
…id populating of data attribute), add GLoBES to list of optional modules, add initialisation examples for several services
…r for xsec.dis_sys; instantiation examples for three data services
…e standalone mode flag and an attribute for the pre-setup data); get hypersurfaces test to work (and ultrasurfaces, but only prelim.); + minor
…ck into instance method, execute calc_mode setter code only when change requested, document
… reps. for several services supporting only binnings, make their tests succeed
… setup-time warning about missing container keys for now
…ip for now; raise exception after completion of service tests with >= 1 failure
…s for data.toy_event_generator for correct inference of flav
@JanWeldert JanWeldert marked this pull request as ready for review August 29, 2024 12:25
@thehrh
Copy link
Contributor Author

thehrh commented Sep 24, 2024

resolves #795

@philippeller
Copy link
Collaborator

These are really welcome changes and improvements to the entire codebase!

The PR contains:

  • (probably automatic?) formatting changes: not reviewed by me ❔
  • changes to the core functions: looking good to me, and are adding explicitness ✅
  • changes to the actual stages, mostly reflecting changes in the core: I did not go through each stage 1:1, but changes lookg good from far away ☑️
  • more testing: I assume these are fine, since they pass (right?) ❔

@JanWeldert
Copy link
Contributor

The formatting changes were done by Thomas manually. So no automatic tool that can screw up our code.
It took some time but now all stages (except for osc.external' and 'flux.airs' which are ignored) pass their test. That doesn't necessarily mean it makes sense (from a physics point of view) what they do but their implementation works and it is easy to run them with some dummy examples. At the end, this is all we check here.

Copy link
Collaborator

@philippeller philippeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, sounds reasonable! From my side green light 🚥

@JanWeldert JanWeldert merged commit e6bff6e into icecube:master Oct 1, 2024
2 checks passed
@JanWeldert JanWeldert deleted the stage_declare_expected_keys branch October 1, 2024 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants