Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: only override weights for new node ids #17175

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

fix unit test

482ba7c
Select commit
Loading
Failed to load commit list.
Open

chore: only override weights for new node ids #17175

fix unit test
482ba7c
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Dec 27, 2024 in 0s

64.35% (+0.00%) compared to 83adcee

View this Pull Request on Codecov

64.35% (+0.00%) compared to 83adcee

Details

Codecov Report

Attention: Patch coverage is 96.87500% with 1 line in your changes missing coverage. Please review.

Project coverage is 64.35%. Comparing base (83adcee) to head (482ba7c).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...ode/app/roster/schemas/RosterTransplantSchema.java 92.85% 0 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##               main   #17175   +/-   ##
=========================================
  Coverage     64.34%   64.35%           
+ Complexity    20927    20926    -1     
=========================================
  Files          2552     2552           
  Lines         96041    96037    -4     
  Branches      10048    10050    +2     
=========================================
+ Hits          61799    61803    +4     
+ Misses        30609    30599   -10     
- Partials       3633     3635    +2     
Files with missing lines Coverage Δ
...dera/node/app/state/MerkleStateLifecyclesImpl.java 87.50% <ø> (+17.28%) ⬆️
...om/hedera/node/config/data/NetworkAdminConfig.java 100.00% <ø> (ø)
...e/schemas/V058RosterLifecycleTransitionSchema.java 100.00% <100.00%> (ø)
...ode/app/roster/schemas/RosterTransplantSchema.java 96.55% <92.85%> (-3.45%) ⬇️

... and 3 files with indirect coverage changes

Impacted file tree graph