-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: only override weights for new node ids #17175
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Michael Tinker <[email protected]>
Signed-off-by: Michael Tinker <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #17175 +/- ##
=========================================
Coverage 64.34% 64.35%
+ Complexity 20927 20926 -1
=========================================
Files 2552 2552
Lines 96041 96037 -4
Branches 10048 10050 +2
=========================================
+ Hits 61799 61803 +4
+ Misses 30609 30599 -10
- Partials 3633 3635 +2
|
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesCodacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more |
Signed-off-by: Michael Tinker <[email protected]>
Passed NFT loadtest on Latitude:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added to Comments: it passed 100M load test
Description:
MerkleStateLifecyclesImpl#onUpdateWeight()
an explicit no-op since it no longer affects startup phase state changes.