Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: only override weights for new node ids #17175

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

tinker-michaelj
Copy link
Collaborator

Description:

@tinker-michaelj tinker-michaelj requested review from a team as code owners December 27, 2024 16:13
@tinker-michaelj tinker-michaelj added this to the v0.58 milestone Dec 27, 2024
@tinker-michaelj tinker-michaelj self-assigned this Dec 27, 2024
Copy link

codecov bot commented Dec 27, 2024

Codecov Report

Attention: Patch coverage is 96.87500% with 1 line in your changes missing coverage. Please review.

Project coverage is 64.35%. Comparing base (83adcee) to head (482ba7c).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...ode/app/roster/schemas/RosterTransplantSchema.java 92.85% 0 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##               main   #17175   +/-   ##
=========================================
  Coverage     64.34%   64.35%           
+ Complexity    20927    20926    -1     
=========================================
  Files          2552     2552           
  Lines         96041    96037    -4     
  Branches      10048    10050    +2     
=========================================
+ Hits          61799    61803    +4     
+ Misses        30609    30599   -10     
- Partials       3633     3635    +2     
Files with missing lines Coverage Δ
...dera/node/app/state/MerkleStateLifecyclesImpl.java 87.50% <ø> (+17.28%) ⬆️
...om/hedera/node/config/data/NetworkAdminConfig.java 100.00% <ø> (ø)
...e/schemas/V058RosterLifecycleTransitionSchema.java 100.00% <100.00%> (ø)
...ode/app/roster/schemas/RosterTransplantSchema.java 96.55% <92.85%> (-3.45%) ⬇️

... and 3 files with indirect coverage changes

Impacted file tree graph

Copy link

codacy-production bot commented Dec 27, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.01% (target: -1.00%) 100.00%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (83adcee) 95804 65240 68.10%
Head commit (482ba7c) 95800 (-4) 65246 (+6) 68.11% (+0.01%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#17175) 32 32 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Signed-off-by: Michael Tinker <[email protected]>
@alex-kuzmin-hg
Copy link
Contributor

Passed NFT loadtest on Latitude:
10 nodes, 100M acc/100M NFTs, 3 hours

https://github.com/swirldslabs/performance-analysis-automation/actions/runs/12529499975/job/34945166401

12-29 00:03:45:887 [main] INFO com.hedera.benchmark.NftTransferLoadTest - Finished NftTransferLoadTest: 80068387 transferred in 7200 sec, TPS: 11120
No errors, no file leaks

Copy link
Contributor

@alex-kuzmin-hg alex-kuzmin-hg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added to Comments: it passed 100M load test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Only use override roster weights for nodes not already in state
2 participants