-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Support for Yaml configuration and List values #17088
Conversation
Signed-off-by: Timo Brandstätter <[email protected]>
Signed-off-by: Timo Brandstätter <[email protected]>
Signed-off-by: Timo Brandstätter <[email protected]>
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesCodacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Next to the given comments an update of the config documentation is needed.
hedera-node/hedera-config/src/main/java/com/hedera/node/config/sources/DynamicConfigSource.java
Show resolved
Hide resolved
hedera-node/hedera-config/src/main/java/com/hedera/node/config/sources/YamlConfigSource.java
Outdated
Show resolved
Hide resolved
hedera-node/hedera-config/src/main/java/com/hedera/node/config/sources/YamlConfigSource.java
Outdated
Show resolved
Hide resolved
hedera-node/hedera-config/src/main/java/com/hedera/node/config/sources/YamlConfigSource.java
Outdated
Show resolved
Hide resolved
...ra-node/hedera-config/src/main/java/com/hedera/node/config/sources/PropertyConfigSource.java
Show resolved
Hide resolved
...onfig-extensions/src/main/java/com/swirlds/config/extensions/sources/SimpleConfigSource.java
Outdated
Show resolved
Hide resolved
...onfig-extensions/src/main/java/com/swirlds/config/extensions/sources/SimpleConfigSource.java
Outdated
Show resolved
Hide resolved
...irlds-config-impl/src/main/java/com/swirlds/config/impl/converters/InetAddressConverter.java
Show resolved
Hide resolved
...dk/swirlds-config-impl/src/main/java/com/swirlds/config/impl/internal/ConfigurationImpl.java
Show resolved
Hide resolved
...dk/swirlds-config-impl/src/main/java/com/swirlds/config/impl/internal/ConfigurationImpl.java
Show resolved
Hide resolved
Signed-off-by: Timo Brandstätter <[email protected]>
Signed-off-by: Timo Brandstätter <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- platform-sdk/swirlds-config-extensions/src/main/java/module-info.java
LGTM.
Please let me know if you want me to review any other code, although I'm not an owner of anything else in this PR.
...-config-extensions/src/main/java/com/swirlds/config/extensions/sources/YamlConfigSource.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Timo Brandstätter <[email protected]>
d1cf1bc
hedera-node/hedera-config/src/main/java/com/hedera/node/config/sources/DynamicConfigSource.java
Show resolved
Hide resolved
hedera-node/hedera-config/src/main/java/com/hedera/node/config/sources/DynamicConfigSource.java
Show resolved
Hide resolved
...ra-node/hedera-config/src/main/java/com/hedera/node/config/sources/PropertyConfigSource.java
Show resolved
Hide resolved
...ra-node/hedera-config/src/main/java/com/hedera/node/config/sources/PropertyConfigSource.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks @timo0
Part of #17075