Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor all ConfigSources to support lists #17102

Open
timo0 opened this issue Dec 18, 2024 · 0 comments
Open

Refactor all ConfigSources to support lists #17102

timo0 opened this issue Dec 18, 2024 · 0 comments
Labels
Platform Tickets pertaining to the platform

Comments

@timo0
Copy link
Member

timo0 commented Dec 18, 2024

With #17088 we introduced lists.

Before this was not supported by the ConfigSource still it was possible by convention to get comma separated values as lists.

Now we have some "hack" in the ConfigurationImpl.java to support both methods:

        if (!propertiesService.isListProperty(propertyName)) {
            final String value = getValue(propertyName);
            values = ConfigListUtils.createList(value);
        } else {
            values = getValues(propertyName);
        }

This should be refactored and in the same way the AbstractConfigSource can be refactored to support list properties in a generic way

@timo0 timo0 added the Platform Tickets pertaining to the platform label Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Platform Tickets pertaining to the platform
Projects
None yet
Development

No branches or pull requests

1 participant