Fix sonar issues #9979
Merged
Fix sonar issues #9979
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdimitrov9
force-pushed
the
9010-fix-sonarcloud-issues
branch
2 times, most recently
from
9668a71 to
23d76fb
Compare
Signed-off-by: sdimitrov9 <[email protected]>
sdimitrov9
force-pushed
the
9010-fix-sonarcloud-issues
branch
from
23d76fb to
a0c5411
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9979 +/- ##
============================================
- Coverage 92.32% 92.32% -0.01%
+ Complexity 7748 7747 -1
============================================
Files 938 938
Lines 32636 32635 -1
Branches 4125 4125
============================================
- Hits 30132 30131 -1
Misses 1533 1533
Partials 971 971 ☔ View full report in Codecov by Sentry. |
sdimitrov9
force-pushed
the
9010-fix-sonarcloud-issues
branch
from
da8b902 to
cd70638
Compare
Signed-off-by: sdimitrov9 <[email protected]>
sdimitrov9
force-pushed
the
9010-fix-sonarcloud-issues
branch
from
cd70638 to
97ee83d
Compare
Signed-off-by: Stoyan Dimitrov <[email protected]>
…ages Signed-off-by: sdimitrov9 <[email protected]>
…raph/hedera-mirror-node into 9010-fix-sonarcloud-issues
steven-sheehy
requested changes
Dec 18, 2024
...test/java/com/hedera/mirror/importer/downloader/provider/AbstractStreamFileProviderTest.java
Outdated
Show resolved
Hide resolved
...test/java/com/hedera/mirror/importer/downloader/provider/AbstractStreamFileProviderTest.java
Outdated
Show resolved
Hide resolved
.../test/java/com/hedera/mirror/importer/migration/UpdateTokenFreezeKycStatusMigrationTest.java
Outdated
Show resolved
Hide resolved
...irror-web3/src/main/java/com/hedera/services/fees/usage/token/entities/TokenEntitySizes.java
Outdated
Show resolved
Hide resolved
Signed-off-by: sdimitrov9 <[email protected]>
|
steven-sheehy
approved these changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Fix sonar issues. Most of the issues left outside of the PR are related to web3 copied services code.
Related issue(s):
Related to #9010
Notes for reviewer:
Test
wipesSerialsWhenApprovedForAll()is now deleted since it duplicates another test's content since its creation. Several 4+ years old TODOs are removed from tests.Checklist