Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix code smells #9010

Open
steven-sheehy opened this issue Aug 12, 2024 · 5 comments
Open

Fix code smells #9010

steven-sheehy opened this issue Aug 12, 2024 · 5 comments
Assignees
@sdimitrov9
Labels
enhancement Type: New feature good first issue Good for newcomers technical debt
Milestone
0.121.0

Comments

@steven-sheehy
Copy link
Member

steven-sheehy commented Aug 12, 2024 •
edited
Loading

Problem

The number of code smells has spiked recently, most likely due to some rule changes on sonar side.

Solution

  • Fix as many code smells as possible:
    • Don't touch web3 copied services code
    • Break into multiple PRs perhaps by fixing all smells for the largest rule first, then the next largest, etc.
    • Don't suppress any warnings in the code or in the UI unless approved with the team beforehand

Alternatives

No response
@steven-sheehy steven-sheehy added the good first issue Good for newcomers label Dec 3, 2024
@sdimitrov9 sdimitrov9 self-assigned this Dec 4, 2024
@sdimitrov9 sdimitrov9 mentioned this issue Dec 4, 2024
Merged
2 tasks
@sdimitrov9
Copy link
Contributor

The latest PR fixed 100+ issues: #9867
Before:
Screenshot 2024-12-04 at 14 48 06
After:
Screenshot 2024-12-05 at 9 24 55

@steven-sheehy steven-sheehy moved this to 🏃‍♀ Sprint backlog in Mirror Node Dec 9, 2024
@steven-sheehy steven-sheehy moved this from 🏃‍♀ Sprint backlog to 👷 In progress in Mirror Node Dec 9, 2024
@steven-sheehy steven-sheehy added this to the 0.121.0 milestone Dec 9, 2024
@sdimitrov9
Copy link
Contributor

More issues fixed after latest PR was merged: #9910
Screenshot 2024-12-11 at 9 52 17

@sdimitrov9
Copy link
Contributor

sdimitrov9 commented Dec 17, 2024 •
edited
Loading

After latest batch of fixes being merged: #9944

Screenshot 2024-12-17 at 15 55 58

@steven-sheehy steven-sheehy mentioned this issue Dec 18, 2024
Merged
2 tasks
@sdimitrov9
Copy link
Contributor

After latest PR being merged #9979
Screenshot 2024-12-20 at 16 42 51

@sdimitrov9
Copy link
Contributor

After merging the latest PR #9996:
Screenshot 2025-01-02 at 9 29 05

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sdimitrov9 sdimitrov9

Labels
enhancement Type: New feature good first issue Good for newcomers technical debt
Projects
Mirror Node
Status: 👷 In progress
Milestone
0.121.0
Development

No branches or pull requests
2 participants
@steven-sheehy @sdimitrov9