chore: add precheck for receivers account in sendRawTransactionCheck #3310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nadezhdapopovaa
requested review from
AlfredoG87,
lukelee-sl and
a team
as code owners
nadezhdapopovaa
force-pushed
the
3286-add-prechecks-to-the-sendrawtransaction-method-to-verify-the-validity-of-the-receivers-account-address
branch
from
589773c to
92c28db
Compare
quiet-node
requested changes
Dec 5, 2024
quiet-node
reviewed
Dec 5, 2024
nadezhdapopovaa
force-pushed
the
3286-add-prechecks-to-the-sendrawtransaction-method-to-verify-the-validity-of-the-receivers-account-address
branch
2 times, most recently
from
66403c6 to
7931099
Compare
Signed-off-by: Nadezhda Popova <[email protected]>
…nCheck Signed-off-by: Nadezhda Popova <[email protected]>
…nsactionCheck Signed-off-by: Nadezhda Popova <[email protected]>
Signed-off-by: Nadezhda Popova <[email protected]>
nadezhdapopovaa
force-pushed
the
3286-add-prechecks-to-the-sendrawtransaction-method-to-verify-the-validity-of-the-receivers-account-address
branch
from
7931099 to
3b85b1a
Compare
quiet-node
requested changes
Dec 11, 2024
Signed-off-by: Nadezhda Popova <[email protected]>
Signed-off-by: Nadezhda Popova <[email protected]>
Signed-off-by: Nadezhda Popova <[email protected]>
…heck Signed-off-by: Nadezhda Popova <[email protected]>
natanasow
previously approved these changes
Dec 13, 2024
victor-yanev
previously approved these changes
Dec 13, 2024
…nt precheck Signed-off-by: Nadezhda Popova <[email protected]>
nadezhdapopovaa
dismissed stale reviews from victor-yanev and natanasow
via
f43a76e
…s account precheck Signed-off-by: Nadezhda Popova <[email protected]>
konstantinabl
previously approved these changes
Dec 13, 2024
quiet-node
previously approved these changes
Dec 13, 2024
…eceivers account precheck Signed-off-by: Nadezhda Popova <[email protected]>
nadezhdapopovaa
dismissed stale reviews from quiet-node and konstantinabl
via
2ccf78d
|
konstantinabl
approved these changes
Dec 16, 2024
quiet-node
approved these changes
Dec 16, 2024
nadezhdapopovaa
deleted the
3286-add-prechecks-to-the-sendrawtransaction-method-to-verify-the-validity-of-the-receivers-account-address
branch
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3310 +/- ##
==========================================
- Coverage 84.91% 84.91% -0.01%
==========================================
Files 69 69
Lines 4655 4660 +5
Branches 1042 1044 +2
==========================================
+ Hits 3953 3957 +4
Misses 397 397
- Partials 305 306 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Added precheck for receiver's account in sendRawTransactionCheck
Fixes #3286