Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add prechecks to the sendRawTransaction method to verify the validity of the receiver's account address. #3286

Closed
quiet-node opened this issue Nov 21, 2024 · 0 comments · Fixed by #3310
Closed

Add prechecks to the sendRawTransaction method to verify the validity of the receiver's account address. #3286

quiet-node opened this issue Nov 21, 2024 · 0 comments · Fixed by #3310
Assignees
@nadezhdapopovaa
Labels
enhancement New feature or request
Milestone
0.63.0

Comments

@quiet-node
Copy link
Member

quiet-node commented Nov 21, 2024 •
edited
Loading

Problem

The Relay currently lacks prechecks to verify the validity of the receiver account for cryptocurrency transfer transactions submitted through the eth_sendRawTransaction endpoint. Additionally, the prechecks should confirm the receiver account must NOT have receiverSigRequired enabled.

Solution

Implement precheck methods to validate the receiver account and ensure that the receiver's receiverSigRequired is NOT enabled.

Alternatives

No response
@quiet-node quiet-node added the enhancement New feature or request label Nov 21, 2024
@quiet-node quiet-node added this to the 0.61.0 milestone Nov 21, 2024
@Nana-EC Nana-EC moved this from Backlog to Sprint Backlog in Smart Contract Sprint Board Nov 22, 2024
@quiet-node quiet-node modified the milestones: 0.61.0, 0.62.0 Nov 26, 2024
@nadezhdapopovaa nadezhdapopovaa self-assigned this Nov 29, 2024
@nadezhdapopovaa nadezhdapopovaa moved this from Sprint Backlog to Tasks In Progress in Smart Contract Sprint Board Nov 29, 2024
@nadezhdapopovaa nadezhdapopovaa mentioned this issue Dec 5, 2024
Merged
@nadezhdapopovaa nadezhdapopovaa linked a pull request Dec 5, 2024 that will close this issue
chore: add precheck for receivers account in sendRawTransactionCheck #3310
Merged
@nadezhdapopovaa nadezhdapopovaa moved this from Tasks In Progress to In Review in Smart Contract Sprint Board Dec 5, 2024
@quiet-node quiet-node modified the milestones: 0.62.0, 0.63.0 Dec 13, 2024
@github-project-automation github-project-automation bot moved this from In Review to Done in Smart Contract Sprint Board Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nadezhdapopovaa nadezhdapopovaa

Labels
enhancement New feature or request
Projects
Smart Contract Sprint Board
Status: Done
Milestone
0.63.0
Development

Successfully merging a pull request may close this issue.

chore: add precheck for receivers account in sendRawTransactionCheck hashgraph/hedera-json-rpc-relay
2 participants
@nadezhdapopovaa @quiet-node