fix: Add websocket-batch-n to needs clause in manual-testing #3307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**Description**: Fixes breaking change in manual-testing.yaml where websocket was split into three batches but the batches were not included in the publish-results needs clause. **Related Issue(s)**: Fixes #3306 Signed-off-by: Roger Barker <[email protected]>
rbarkerSL
requested review from
jeromy-cannon,
nathanklick,
victor-yanev and
andrewb1269hg
rbarkerSL
requested review from
AlfredoG87,
Nana-EC and
a team
as code owners
|
Test Results 22 files - 1 291 suites - 19 45m 1s ⏱️ - 13m 15s For more details on these failures, see this check. Results for commit 9f43457. ± Comparison against base commit af2159f. This pull request removes 2 and adds 1 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
nathanklick
approved these changes
Dec 4, 2024
victor-yanev
approved these changes
Dec 4, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3307 +/- ##
==========================================
- Coverage 84.98% 84.90% -0.09%
==========================================
Files 65 69 +4
Lines 4456 4636 +180
Branches 1014 1041 +27
==========================================
+ Hits 3787 3936 +149
- Misses 331 396 +65
+ Partials 338 304 -34
Flags with carried forward coverage won't be shown. Click here to find out more. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Fixes breaking change in manual-testing.yaml where websocket was split into three batches but the batches were not included in the publish-results needs clause.
Related Issue(s):
Fixes #3306
Notes for Reviewer: