Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix breaking change in manual-testing.yaml #3306

Closed
rbarkerSL opened this issue Dec 4, 2024 · 0 comments · Fixed by #3307
Closed

Fix breaking change in manual-testing.yaml #3306

rbarkerSL opened this issue Dec 4, 2024 · 0 comments · Fixed by #3307
Assignees
@rbarkerSL
Labels
github_action
Milestone
0.62.0

Comments

@rbarkerSL
Copy link
Contributor

#3027 breaks the manual-testing.yaml workflow.

The publish_results step now needs to include the websocket-batch jobs instead of the websocket job in the needs clause.
@rbarkerSL rbarkerSL added this to the 0.62.0 milestone Dec 4, 2024
@rbarkerSL rbarkerSL self-assigned this Dec 4, 2024
rbarkerSL added a commit that referenced this issue Dec 4, 2024
@rbarkerSL
fix: Add websocket-batch-n to needs clause in manual-testing
9f43457 
**Description**:

Fixes breaking change in manual-testing.yaml where websocket was split
into three batches but the batches were not included in the
publish-results needs clause.

**Related Issue(s)**:

Fixes #3306

Signed-off-by: Roger Barker <[email protected]>
@rbarkerSL rbarkerSL mentioned this issue Dec 4, 2024
Merged
1 task
@rbarkerSL rbarkerSL linked a pull request Dec 4, 2024 that will close this issue
fix: Add websocket-batch-n to needs clause in manual-testing #3307
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rbarkerSL rbarkerSL

Labels
github_action
Projects
None yet
Milestone
0.62.0
Development

Successfully merging a pull request may close this issue.

fix: Add websocket-batch-n to needs clause in manual-testing hashgraph/hedera-json-rpc-relay
1 participant
@rbarkerSL