ATO-983: Get InternalCommonSubjectIdentifier From AuthSession (Auth ICSID 2/3) #5455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
mentioned this pull request
1 task
ghost
changed the title
ghost
changed the title
ghost
mentioned this pull request
1 task
ghost
force-pushed
the
ATO-983/Get-InternalCommonSubjectIdentifier-From-AuthSession
branch
4 times, most recently
from
fa3fc72 to
2fb578c
Compare
ghost
force-pushed
the
ATO-983/Get-InternalCommonSubjectIdentifier-From-AuthSession
branch
11 times, most recently
from
c326ca6 to
02d9d3c
Compare
ghost
marked this pull request as ready for review
ghost
force-pushed
the
ATO-983/Get-InternalCommonSubjectIdentifier-From-AuthSession
branch
from
02d9d3c to
bc49eca
Compare
alhcomer
reviewed
Nov 19, 2024
| authSessionService.getSessionFromRequestHeaders(input.getHeaders()); | ||
| if (authSession.isEmpty()) { | ||
| if (authSessionOptional.isEmpty()) { |
There was a problem hiding this comment.
It might be good to assign the optional to a variable rather than calling get throughout the handler
There was a problem hiding this comment.
Yes, that'd be better and is more consistent with what's done in the verify mfa code handler
added 4 commits
November 19, 2024 11:23
added 7 commits
November 19, 2024 11:23
Update UpdateProfileIntegrationTest.java
ghost
force-pushed
the
ATO-983/Get-InternalCommonSubjectIdentifier-From-AuthSession
branch
from
bc49eca to
a1e81cf
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Use Internal Common Subject Identifier From Auth Session
How to review
Checklist
Previous PR: #5396
Next PR: #5454