Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ATO-983: Set InternalCommonSubjectIdentifier In AuthSession (Auth ICSID 1/3) #5396

Merged
1 commit merged into from
Nov 7, 2024

Conversation

ghost
Copy link

@ghost ghost commented Oct 16, 2024

What

Set Internal Common Subject Identifier In Auth Session

How to review

  1. Code Review

Checklist

  • Impact on orch and auth mutual dependencies has been checked.

Next PR: #5455

@ghost ghost force-pushed the ATO-983/Set-InternalCommonSubjectIdentifier branch 3 times, most recently from a7c40bd to 1dcc9db Compare October 16, 2024 13:00
@ghost ghost changed the title Ato 983/set internal common subject identifier Ato 983/set internal common subject identifier (1) Oct 17, 2024
@ghost ghost marked this pull request as ready for review October 17, 2024 08:40
@ghost ghost requested review from a team as code owners October 17, 2024 08:40
@ghost ghost marked this pull request as draft October 17, 2024 11:02
@ghost ghost marked this pull request as ready for review October 17, 2024 11:55
@ghost ghost force-pushed the ATO-983/Set-InternalCommonSubjectIdentifier branch from 1dcc9db to c7eaea4 Compare October 24, 2024 11:05
@ghost ghost requested a review from billrdunn October 24, 2024 11:07
@ghost ghost force-pushed the ATO-983/Set-InternalCommonSubjectIdentifier branch from c7eaea4 to 6320aeb Compare October 24, 2024 16:00
@ghost ghost force-pushed the ATO-983/Set-InternalCommonSubjectIdentifier branch from 6320aeb to 3701853 Compare October 29, 2024 14:18
@ghost ghost changed the title Ato 983/set internal common subject identifier (1) ATO-983: Set InternalCommonSubjectIdentifier In AuthSession (Auth 1/3) Oct 29, 2024
@ghost ghost changed the title ATO-983: Set InternalCommonSubjectIdentifier In AuthSession (Auth 1/3) ATO-983: Set InternalCommonSubjectIdentifier In AuthSession (Auth ICSID 1/3) Oct 29, 2024
@ghost ghost force-pushed the ATO-983/Set-InternalCommonSubjectIdentifier branch from 3701853 to 945cf59 Compare October 31, 2024 09:46
@ghost ghost force-pushed the ATO-983/Set-InternalCommonSubjectIdentifier branch 3 times, most recently from 052844b to e5c1ea8 Compare November 6, 2024 10:09
@ghost ghost force-pushed the ATO-983/Set-InternalCommonSubjectIdentifier branch from e5c1ea8 to d27f03c Compare November 6, 2024 10:23
Copy link

sonarqubecloud bot commented Nov 6, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
1 New Code Smells (required ≤ 0)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@ghost ghost added this pull request to the merge queue Nov 7, 2024
@ghost ghost removed this pull request from the merge queue due to a manual request Nov 7, 2024
@ghost ghost added this pull request to the merge queue Nov 7, 2024
Merged via the queue into main with commit cb7b853 Nov 7, 2024
20 of 21 checks passed
@ghost ghost deleted the ATO-983/Set-InternalCommonSubjectIdentifier branch November 7, 2024 15:14
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants