-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ATO-983: Set InternalCommonSubjectIdentifier In AuthSession (Auth ICSID 1/3) #5396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
force-pushed
the
ATO-983/Set-InternalCommonSubjectIdentifier
branch
3 times, most recently
from
October 16, 2024 13:00
a7c40bd
to
1dcc9db
Compare
ghost
changed the title
Ato 983/set internal common subject identifier
Ato 983/set internal common subject identifier (1)
Oct 17, 2024
ghost
marked this pull request as ready for review
October 17, 2024 08:40
ghost
marked this pull request as draft
October 17, 2024 11:02
ghost
marked this pull request as ready for review
October 17, 2024 11:55
ethanmills
reviewed
Oct 17, 2024
frontend-api/src/main/java/uk/gov/di/authentication/frontendapi/helpers/SessionHelper.java
Outdated
Show resolved
Hide resolved
ghost
force-pushed
the
ATO-983/Set-InternalCommonSubjectIdentifier
branch
from
October 24, 2024 11:05
1dcc9db
to
c7eaea4
Compare
ghost
requested a review
from billrdunn
October 24, 2024 11:07
ghost
force-pushed
the
ATO-983/Set-InternalCommonSubjectIdentifier
branch
from
October 24, 2024 16:00
c7eaea4
to
6320aeb
Compare
ghost
force-pushed
the
ATO-983/Set-InternalCommonSubjectIdentifier
branch
from
October 29, 2024 14:18
6320aeb
to
3701853
Compare
ghost
changed the title
Ato 983/set internal common subject identifier (1)
ATO-983: Set InternalCommonSubjectIdentifier In AuthSession (Auth 1/3)
Oct 29, 2024
ghost
mentioned this pull request
Oct 29, 2024
1 task
ghost
changed the title
ATO-983: Set InternalCommonSubjectIdentifier In AuthSession (Auth 1/3)
ATO-983: Set InternalCommonSubjectIdentifier In AuthSession (Auth ICSID 1/3)
Oct 29, 2024
ghost
force-pushed
the
ATO-983/Set-InternalCommonSubjectIdentifier
branch
from
October 31, 2024 09:46
3701853
to
945cf59
Compare
billrdunn
reviewed
Nov 4, 2024
...nd-api/src/main/java/uk/gov/di/authentication/frontendapi/lambda/CheckUserExistsHandler.java
Outdated
Show resolved
Hide resolved
...nd-api/src/main/java/uk/gov/di/authentication/frontendapi/lambda/CheckUserExistsHandler.java
Outdated
Show resolved
Hide resolved
ghost
force-pushed
the
ATO-983/Set-InternalCommonSubjectIdentifier
branch
3 times, most recently
from
November 6, 2024 10:09
052844b
to
e5c1ea8
Compare
ghost
force-pushed
the
ATO-983/Set-InternalCommonSubjectIdentifier
branch
from
November 6, 2024 10:23
e5c1ea8
to
d27f03c
Compare
Quality Gate failedFailed conditions See analysis details on SonarCloud Catch issues before they fail your Quality Gate with our IDE extension SonarLint |
alhcomer
approved these changes
Nov 6, 2024
ghost
added this pull request to the merge queue
Nov 7, 2024
ghost
removed this pull request from the merge queue due to a manual request
Nov 7, 2024
ghost
added this pull request to the merge queue
Nov 7, 2024
ghost
deleted the
ATO-983/Set-InternalCommonSubjectIdentifier
branch
November 7, 2024 15:14
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Set Internal Common Subject Identifier In Auth Session
How to review
Checklist
Next PR: #5455