Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.x] Allow falling back to GLES2 #118

Open
wants to merge 1 commit into
base: 3.x
Choose a base branch
from

Conversation

Calinou
Copy link
Member

@Calinou Calinou commented Jan 10, 2022

This allows running the TPS demo on a greater range of devices and platforms, while also allowing its use for GLES2 renderer testing.

Several automatic adjustments are made to ensure it looks as good as possible (within the limitations of GLES2 and the lack of baked lightmaps).

Some particles are currently missing and would need CPUParticles fallbacks to be added to become visible again.

Edit: Bullet bodies/trails are now visible in GLES2 as this PR converts them to CPUParticles. They look identical to before in GLES3.
Bullet explosions are still missing, but they use custom particle shaders so a complete rewrite would be required.

To test this locally, start the project with the --video-driver GLES2 command line argument (or add --video-driver GLES2 to the Main Run Args project setting).

2022-01-10_18 57 43

@aaronfranke aaronfranke self-requested a review January 10, 2022 18:07
@Calinou Calinou mentioned this pull request Feb 25, 2022
@Calinou Calinou marked this pull request as ready for review August 6, 2022 03:10
@Calinou Calinou force-pushed the allow-gles2-fallback branch from 2f97cf7 to 0dc21a2 Compare August 6, 2022 04:55
@Calinou
Copy link
Member Author

Calinou commented Aug 6, 2022

Rebased and tested again, it works as expected on Godot 3.5.

I converted the bullet's main body and trail particles to CPUParticles so that bullets are visible in GLES2 too.

@Calinou
Copy link
Member Author

Calinou commented Sep 7, 2022

I made a branch with GLES2 + lightmaps if anyone is interested: https://github.com/Calinou/tps-demo/tree/allow-gles2-fallback-lightmaps

This allows running the TPS demo on a greater range of devices
and platforms, while also allowing its use for GLES2 renderer testing.

Several automatic adjustments are made to ensure it looks as good
as possible (within the limitations of GLES2 and the lack of baked
lightmaps).
@Calinou Calinou force-pushed the allow-gles2-fallback branch from 0dc21a2 to 18c4ba2 Compare September 11, 2022 17:13
@Calinou Calinou changed the base branch from master to 3.x June 28, 2023 10:01
@akien-mga akien-mga changed the title Allow falling back to GLES2 [3.x] Allow falling back to GLES2 Nov 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant