Add a setting to disable real-time light shadows #140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Disabling shadows reduces the number of draw calls significantly, which improves rendering performance a lot.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disabling shadows reduces the number of draw calls significantly, which improves rendering performance a lot.
Since the demo doesn't have too many bright point lights, the visual difference isn't that noticeable (except when walking under a light).
This will come particularly handy on integrated graphics and on mobile (once #118 is merged).
Benchmark
FPS over time when following the path from spawn to the reactor room. Using the default graphics settings in 2560×1440 on a GeForce GTX 1080: