-
-
Notifications
You must be signed in to change notification settings - Fork 338
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(ci): Fixes performance tests failure due to Boost dependency URL unavailability #4414
Merged
+30
−172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antonis
changed the title
chore(ci): Bumps RN to 0.70.15 that includes the Boost fix
chore(ci): Fixes performance test failure due to Boost dependency URL unavailability
Jan 3, 2025
Android (new) Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
690220d+dirty | 492.10 ms | 473.88 ms | -18.23 ms |
8e80789+dirty | 464.48 ms | 551.10 ms | 86.63 ms |
d8e8c67+dirty | 363.77 ms | 408.66 ms | 44.89 ms |
484813b+dirty | 411.65 ms | 456.02 ms | 44.37 ms |
13f280b+dirty | 376.13 ms | 406.41 ms | 30.28 ms |
8ae23a7+dirty | 398.10 ms | 411.48 ms | 13.38 ms |
12427f4+dirty | 379.48 ms | 400.92 ms | 21.44 ms |
1faf8e3+dirty | 412.83 ms | 470.49 ms | 57.66 ms |
0677344+dirty | 288.40 ms | 391.44 ms | 103.04 ms |
63ed251+dirty | 485.02 ms | 531.16 ms | 46.14 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
690220d+dirty | 7.15 MiB | 8.36 MiB | 1.21 MiB |
8e80789+dirty | 7.15 MiB | 8.37 MiB | 1.22 MiB |
d8e8c67+dirty | 7.15 MiB | 8.38 MiB | 1.23 MiB |
484813b+dirty | 7.15 MiB | 8.34 MiB | 1.19 MiB |
13f280b+dirty | 7.15 MiB | 8.35 MiB | 1.20 MiB |
8ae23a7+dirty | 7.15 MiB | 8.35 MiB | 1.20 MiB |
12427f4+dirty | 7.15 MiB | 8.12 MiB | 997.78 KiB |
1faf8e3+dirty | 7.15 MiB | 8.35 MiB | 1.20 MiB |
0677344+dirty | 7.15 MiB | 8.07 MiB | 949.80 KiB |
63ed251+dirty | 7.15 MiB | 8.35 MiB | 1.20 MiB |
antonis
changed the title
chore(ci): Fixes performance test failure due to Boost dependency URL unavailability
chore(ci): Fixes performance tests failure due to Boost dependency URL unavailability
Jan 3, 2025
antonis
requested review from
krystofwoldrich and
lucas-zimerman
as code owners
January 3, 2025 11:28
Android (legacy) Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
e2b64fe | 316.88 ms | 330.23 ms | 13.35 ms |
9c48b2c | 349.24 ms | 385.96 ms | 36.72 ms |
d43a46b | 454.22 ms | 477.79 ms | 23.57 ms |
8ab11b6 | 462.10 ms | 450.40 ms | -11.70 ms |
0ebca77 | 414.93 ms | 444.49 ms | 29.56 ms |
62a750b | 395.96 ms | 423.36 ms | 27.41 ms |
0d3e677 | 422.82 ms | 411.90 ms | -10.92 ms |
1d86dd6 | 405.14 ms | 411.06 ms | 5.92 ms |
1332acb | 493.40 ms | 475.20 ms | -18.21 ms |
9282172 | 486.12 ms | 467.70 ms | -18.42 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
e2b64fe | 17.73 MiB | 19.80 MiB | 2.07 MiB |
9c48b2c | 17.73 MiB | 19.80 MiB | 2.07 MiB |
d43a46b | 17.73 MiB | 20.06 MiB | 2.33 MiB |
8ab11b6 | 17.74 MiB | 20.09 MiB | 2.35 MiB |
0ebca77 | 17.73 MiB | 19.95 MiB | 2.21 MiB |
62a750b | 17.73 MiB | 19.93 MiB | 2.20 MiB |
0d3e677 | 17.74 MiB | 20.07 MiB | 2.34 MiB |
1d86dd6 | 17.73 MiB | 19.86 MiB | 2.12 MiB |
1332acb | 17.74 MiB | 20.09 MiB | 2.35 MiB |
9282172 | 17.74 MiB | 20.09 MiB | 2.35 MiB |
romtsn
approved these changes
Jan 3, 2025
iOS (new) Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
5a22220+dirty | 1246.18 ms | 1249.61 ms | 3.43 ms |
f06c879+dirty | 1285.14 ms | 1285.86 ms | 0.72 ms |
c398f67+dirty | 1227.31 ms | 1230.00 ms | 2.69 ms |
5bb8d5f+dirty | 1215.04 ms | 1217.52 ms | 2.48 ms |
4cc5c27+dirty | 1220.43 ms | 1215.13 ms | -5.30 ms |
b95b8af+dirty | 1235.60 ms | 1242.06 ms | 6.46 ms |
dadc233+dirty | 1266.52 ms | 1282.55 ms | 16.03 ms |
1faf8e3+dirty | 1223.38 ms | 1220.56 ms | -2.82 ms |
7bc4d75+dirty | 1222.13 ms | 1216.39 ms | -5.74 ms |
1332acb+dirty | 1243.98 ms | 1241.12 ms | -2.86 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
5a22220+dirty | 2.92 MiB | 3.48 MiB | 575.81 KiB |
f06c879+dirty | 2.92 MiB | 3.44 MiB | 533.24 KiB |
c398f67+dirty | 2.92 MiB | 3.60 MiB | 701.89 KiB |
5bb8d5f+dirty | 2.92 MiB | 3.48 MiB | 575.85 KiB |
4cc5c27+dirty | 2.92 MiB | 3.61 MiB | 705.47 KiB |
b95b8af+dirty | 2.92 MiB | 3.69 MiB | 794.16 KiB |
dadc233+dirty | 2.92 MiB | 3.40 MiB | 492.53 KiB |
1faf8e3+dirty | 2.92 MiB | 3.64 MiB | 742.61 KiB |
7bc4d75+dirty | 2.92 MiB | 3.66 MiB | 757.15 KiB |
1332acb+dirty | 2.92 MiB | 3.67 MiB | 772.45 KiB |
iOS (legacy) Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
5a22220+dirty | 1209.49 ms | 1220.94 ms | 11.45 ms |
f06c879+dirty | 1252.64 ms | 1259.66 ms | 7.02 ms |
c398f67+dirty | 1219.67 ms | 1225.66 ms | 5.99 ms |
5bb8d5f+dirty | 1235.47 ms | 1237.39 ms | 1.92 ms |
4cc5c27+dirty | 1211.45 ms | 1214.60 ms | 3.16 ms |
b95b8af+dirty | 1221.39 ms | 1228.52 ms | 7.13 ms |
dadc233+dirty | 1223.20 ms | 1236.88 ms | 13.68 ms |
1faf8e3+dirty | 1214.87 ms | 1222.83 ms | 7.97 ms |
7bc4d75+dirty | 1233.40 ms | 1229.56 ms | -3.83 ms |
1332acb+dirty | 1230.53 ms | 1234.54 ms | 4.01 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
5a22220+dirty | 2.36 MiB | 2.92 MiB | 570.21 KiB |
f06c879+dirty | 2.36 MiB | 2.88 MiB | 530.42 KiB |
c398f67+dirty | 2.36 MiB | 3.04 MiB | 696.27 KiB |
5bb8d5f+dirty | 2.36 MiB | 2.92 MiB | 570.22 KiB |
4cc5c27+dirty | 2.36 MiB | 3.04 MiB | 698.52 KiB |
b95b8af+dirty | 2.36 MiB | 3.14 MiB | 793.32 KiB |
dadc233+dirty | 2.36 MiB | 2.84 MiB | 486.85 KiB |
1faf8e3+dirty | 2.36 MiB | 3.08 MiB | 736.75 KiB |
7bc4d75+dirty | 2.36 MiB | 3.10 MiB | 752.58 KiB |
1332acb+dirty | 2.36 MiB | 3.11 MiB | 759.86 KiB |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📢 Type of change
📜 Description
0.70.6
to0.70.15
that includes the Boost fix.💡 Motivation and Context
Fixes #4413
💚 How did you test it?
CI
📝 Checklist
sendDefaultPII
is enabled🔮 Next steps
our performance test apps (TestAppPlain/TestAppSentry) on the latest RN version.
#skip-changelog