Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Session Replay is GA #4384

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Conversation

krystofwoldrich
Copy link
Member

@krystofwoldrich krystofwoldrich commented Dec 17, 2024

🛑 Requires

  • Bump to Cocoa with SR GA
  • Bump to Android with SR GA

📜 Description

This PR adds SR GA changelog entry and deprecates _experiments options which will be removed in the next major version.

(I choose to deprecate options in _experiments and not to remove them, as with removal the SR would silently stop working for our beta users.)

This PR updates the native implementation to use GA options of Sentry Cocoa and Android.

💚 How did you test it?

updated tests, native implementation is waiting for the native SDKs update

📝 Checklist

  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • All tests passing
  • No breaking changes

@krystofwoldrich krystofwoldrich requested review from kahest and removed request for antonis and lucas-zimerman December 17, 2024 11:08
Copy link
Contributor

github-actions bot commented Dec 17, 2024

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 1171bb8

Copy link
Contributor

github-actions bot commented Dec 17, 2024

iOS (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1227.28 ms 1229.22 ms 1.95 ms
Size 2.36 MiB 3.11 MiB 759.88 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
7f6950b+dirty 1235.53 ms 1227.30 ms -8.23 ms
31fcca2+dirty 1209.17 ms 1216.21 ms 7.04 ms
8e80789+dirty 1228.04 ms 1237.20 ms 9.16 ms
3ffcddd+dirty 1244.47 ms 1264.14 ms 19.67 ms
a5d86e1+dirty 1242.47 ms 1239.94 ms -2.53 ms
52a8031+dirty 1280.88 ms 1289.78 ms 8.90 ms
70caa60+dirty 1218.27 ms 1230.30 ms 12.03 ms
27ef4ee+dirty 1293.52 ms 1296.08 ms 2.56 ms
ddc0552+dirty 1236.13 ms 1248.17 ms 12.05 ms
8ae23a7+dirty 1230.02 ms 1227.62 ms -2.40 ms

App size

Revision Plain With Sentry Diff
7f6950b+dirty 2.36 MiB 3.11 MiB 760.04 KiB
31fcca2+dirty 2.36 MiB 2.90 MiB 552.95 KiB
8e80789+dirty 2.36 MiB 3.10 MiB 759.43 KiB
3ffcddd+dirty 2.36 MiB 2.84 MiB 489.60 KiB
a5d86e1+dirty 2.36 MiB 3.10 MiB 752.65 KiB
52a8031+dirty 2.36 MiB 2.82 MiB 469.44 KiB
70caa60+dirty 2.36 MiB 2.83 MiB 479.27 KiB
27ef4ee+dirty 2.36 MiB 2.85 MiB 500.03 KiB
ddc0552+dirty 2.36 MiB 3.11 MiB 759.84 KiB
8ae23a7+dirty 2.36 MiB 3.10 MiB 752.42 KiB

Copy link
Contributor

iOS (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1237.76 ms 1231.11 ms -6.65 ms
Size 2.92 MiB 3.67 MiB 772.10 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
7f6950b+dirty 1250.94 ms 1252.92 ms 1.98 ms
31fcca2+dirty 1222.04 ms 1226.51 ms 4.47 ms
8e80789+dirty 1235.66 ms 1223.78 ms -11.88 ms
3ffcddd+dirty 1272.22 ms 1273.98 ms 1.76 ms
a5d86e1+dirty 1230.35 ms 1222.47 ms -7.88 ms
52a8031+dirty 1255.96 ms 1273.00 ms 17.04 ms
70caa60+dirty 1279.08 ms 1281.54 ms 2.46 ms
27ef4ee+dirty 1236.41 ms 1244.90 ms 8.49 ms
ddc0552+dirty 1246.00 ms 1241.98 ms -4.02 ms
8ae23a7+dirty 1233.67 ms 1229.52 ms -4.15 ms

App size

Revision Plain With Sentry Diff
7f6950b+dirty 2.92 MiB 3.67 MiB 772.53 KiB
31fcca2+dirty 2.92 MiB 3.46 MiB 557.31 KiB
8e80789+dirty 2.92 MiB 3.67 MiB 772.00 KiB
3ffcddd+dirty 2.92 MiB 3.40 MiB 494.39 KiB
a5d86e1+dirty 2.92 MiB 3.66 MiB 757.10 KiB
52a8031+dirty 2.92 MiB 3.38 MiB 475.71 KiB
70caa60+dirty 2.92 MiB 3.39 MiB 486.04 KiB
27ef4ee+dirty 2.92 MiB 3.41 MiB 503.72 KiB
ddc0552+dirty 2.92 MiB 3.67 MiB 772.47 KiB
8ae23a7+dirty 2.92 MiB 3.66 MiB 757.67 KiB

"replaysOnErrorSampleRate": 0.75,
"replaysSessionSampleRate": 0.75
]
"replaysOnErrorSampleRate": 0.75,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

l: leading tabs

Suggested change
"replaysOnErrorSampleRate": 0.75,
"replaysOnErrorSampleRate": 0.75,

Copy link
Collaborator

@antonis antonis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for deprecating _experiments for SR 🙇
The changes on this PR LGTM 🚀
I restrain from approving till the Cocoa and Android SDKs land and I can fully test the changes.

NIT: also found a few more places that we may want to update:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants