-
Notifications
You must be signed in to change notification settings - Fork 514
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Add Typer integration #3869
✨ Add Typer integration #3869
Conversation
Thank you @patrick91 ❤️ We will take a look at this next week!
As with all new integrations I'd prefer we leave this as opt-in for a couple of releases and then re-evaluate, just to be safe. |
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## master #3869 +/- ##
==========================================
- Coverage 79.93% 79.89% -0.05%
==========================================
Files 137 138 +1
Lines 15403 15433 +30
Branches 2620 2623 +3
==========================================
+ Hits 12313 12330 +17
- Misses 2219 2229 +10
- Partials 871 874 +3
|
This PR adds an integration for Typer
The integration works by mocking
typer.main.except_hook
, I was chatting with Sebastian and he's willing to add a hook in typer to avoid mocking, but I think it's also fine to keep the code as is 😊The code is inspired by the
ExcepthookIntegration
, same thing for the test, unfortunately there's no way to test a custom except_hook with pytest, so I'm running the CLI using subprocess.Shall I add this to the default integrations? 😊
Closes #1612
Closes #1604