Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(python): Add Typer integration docs #12174

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

feat(python): Add Typer integration docs #12174

wants to merge 4 commits into from

Conversation

sentrivana
Copy link
Contributor

@sentrivana sentrivana commented Dec 18, 2024 •
edited
Loading

DESCRIBE YOUR PR

getsentry/sentry-python#3869 adds the Typer integration to the Python SDK. Adding docs.

Note: This is not released yet, so please don't merge yet. It can however be reviewed already.

IS YOUR CHANGE URGENT?

Help us prioritize incoming PRs by letting us know when the change needs to go live.

  • Urgent deadline (GA date, etc.):
  • Other deadline:
  • None: Not urgent, can wait up to 1 week+

SLA

  • Teamwork makes the dream work, so please add a reviewer to your PRs.
  • Please give the docs team up to 1 week to review your PR unless you've added an urgent due date to it.
    Thanks in advance for your help!

PRE-MERGE CHECKLIST

Make sure you've checked the following before merging your changes:

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs (subject matter experts)
  • PR was reviewed and approved by a member of the Sentry docs team

EXTRA RESOURCES

@vercel Vercel
Copy link

vercel bot commented Dec 18, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 19, 2024 11:26am
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
changelog ⬜️ Ignored (Inspect) Visit Preview Dec 19, 2024 11:26am
develop-docs ⬜️ Ignored (Inspect) Visit Preview Dec 19, 2024 11:26am

@sentrivana sentrivana changed the title Ivana/python/add typer integration feat(python): Add Typer integration docs Dec 18, 2024
@codecov Codecov
Copy link

codecov bot commented Dec 18, 2024 •
edited
Loading

Bundle Report

Changes will increase total bundle size by 180 bytes (0.0%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-server-cjs 10.35MB 186 bytes (0.0%) ⬆️
sentry-docs-client-array-push 9.28MB 6 bytes (-0.0%) ⬇️

@sentrivana sentrivana requested review from antonpirker and a team December 18, 2024 11:45
@sentrivana sentrivana marked this pull request as ready for review December 18, 2024 11:45
coolguyzone
coolguyzone approved these changes Dec 18, 2024
View reviewed changes
Copy link
Contributor

@coolguyzone coolguyzone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding! LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coolguyzone coolguyzone coolguyzone approved these changes

@antonpirker antonpirker Awaiting requested review from antonpirker

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sentrivana @coolguyzone