-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update packages #179
update packages #179
Conversation
4f18c98
to
01ebded
Compare
@cartermp I think I need some holding hands on this ... |
I think maybe you just need to bump the global.json and the github runners? |
Global.json seems fine |
902be3c
to
ee3b457
Compare
Ugh. So I'm pretty sure this is a FAKE issue: fsprojects/FAKE#2753 |
See also: fsprojects/FAKE#2719 So if we need .NET 7+ support, we need to rip out FAKE. It's honestly not a bad idea, FAKE is typically nothing but trouble for the past several years |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@colombod Good news, we're unblocked on the build, but the Fsharp.Core reference is messing up some tests. I think we need to bump them back down.
@@ -86,7 +86,7 @@ | |||
<None Include="..\..\docs\img\logo.png" Pack="true" PackagePath="\" /> | |||
</ItemGroup> | |||
<ItemGroup> | |||
<PackageReference Update="FSharp.Core" Version="4.7.2" /> | |||
<PackageReference Include="Newtonsoft.Json" Version="12.0.3" /> | |||
<PackageReference Update="FSharp.Core" Version="8.0.100" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@colombod I believe this needs to be bumped back down
<ItemGroup> | ||
<PackageReference Update="FSharp.Core" Version="8.0.100" /> | ||
</ItemGroup> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should also not pull in latest FSharp.Core here, esp. since it's an older TFM (.NET 7)
That could make it a problem with net interactive? |
Closing as dealt with in latest main |
upgrading test tfm to net7.0
upgrade to .NET Interactive and other pacakges
upgraded Newtonsoft to latest
change extension loading to use script instead of assembly scanning