Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update packages #179

Closed
wants to merge 4 commits into from
Closed

update packages #179

wants to merge 4 commits into from

Conversation

colombod
Copy link
Collaborator

@colombod colombod commented Nov 23, 2023

upgrading test tfm to net7.0
upgrade to .NET Interactive and other pacakges
upgraded Newtonsoft to latest
change extension loading to use script instead of assembly scanning

@colombod colombod requested a review from cartermp November 23, 2023 09:01
@colombod colombod closed this Nov 23, 2023
@colombod colombod reopened this Nov 23, 2023
@colombod
Copy link
Collaborator Author

@cartermp I think I need some holding hands on this ...

@cartermp
Copy link
Collaborator

I think maybe you just need to bump the global.json and the github runners?

@colombod
Copy link
Collaborator Author

I think maybe you just need to bump the global.json and the github runners?

Global.json seems fine

@cartermp
Copy link
Collaborator

Ugh. So I'm pretty sure this is a FAKE issue: fsprojects/FAKE#2753

@cartermp
Copy link
Collaborator

See also: fsprojects/FAKE#2719

So if we need .NET 7+ support, we need to rip out FAKE. It's honestly not a bad idea, FAKE is typically nothing but trouble for the past several years

@cartermp cartermp closed this Apr 24, 2024
@cartermp cartermp reopened this Apr 24, 2024
Copy link
Collaborator

@cartermp cartermp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@colombod Good news, we're unblocked on the build, but the Fsharp.Core reference is messing up some tests. I think we need to bump them back down.

@@ -86,7 +86,7 @@
<None Include="..\..\docs\img\logo.png" Pack="true" PackagePath="\" />
</ItemGroup>
<ItemGroup>
<PackageReference Update="FSharp.Core" Version="4.7.2" />
<PackageReference Include="Newtonsoft.Json" Version="12.0.3" />
<PackageReference Update="FSharp.Core" Version="8.0.100" />
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@colombod I believe this needs to be bumped back down

Comment on lines +48 to +50
<ItemGroup>
<PackageReference Update="FSharp.Core" Version="8.0.100" />
</ItemGroup>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should also not pull in latest FSharp.Core here, esp. since it's an older TFM (.NET 7)

@colombod
Copy link
Collaborator Author

That could make it a problem with net interactive?

@cartermp
Copy link
Collaborator

Closing as dealt with in latest main

@cartermp cartermp closed this Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants