Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add static setters to KernelExtension. #180

Merged
merged 1 commit into from
Apr 24, 2024
Merged

Conversation

nojaf
Copy link
Contributor

@nojaf nojaf commented Apr 15, 2024

In our corporate environment, we cannot access the public internet and would need to use our own CDN endpoint.

Similar to #145 allows us to set this.

@nojaf
Copy link
Contributor Author

nojaf commented Apr 19, 2024

Hi @zyzhu and @cartermp,

Any chance this could make it in?
We are still using XPlot for some projects and can't easily upgrade.

@cartermp
Copy link
Collaborator

ahhh FFS out of date .NET versions and fake

@nojaf
Copy link
Contributor Author

nojaf commented Apr 22, 2024

@cartermp I replace FAKE with Fun.Build in #181 to avoid the build problem.

@nojaf
Copy link
Contributor Author

nojaf commented Apr 24, 2024

@cartermp the build is green now.

@cartermp cartermp merged commit 3efef90 into fslaborg:main Apr 24, 2024
2 checks passed
@nojaf
Copy link
Contributor Author

nojaf commented Apr 24, 2024

Thanks @cartermp ! Any chance we could get a release with this?

@cartermp
Copy link
Collaborator

I was hoping to get in #179 (comment) first, let me see about this by end of day?

@jonsequitur
Copy link

There's an approach to custom formatters for .NET Interactive that's a bit simpler and doesn't require a reference to the .NET Interactive libraries, if that's interesting.

https://github.com/dotnet/interactive/blob/main/docs/formatting.md#typeformattersourceattribute

@nojaf
Copy link
Contributor Author

nojaf commented Apr 30, 2024

Any updates on this @cartermp?

@cartermp
Copy link
Collaborator

cartermp commented May 4, 2024

Done and done

@nojaf
Copy link
Contributor Author

nojaf commented May 6, 2024

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants