-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[camera] Remove OCMock from tests #8342
Open
mchudy
wants to merge
16
commits into
flutter:main
Choose a base branch
from
leancodepl:feature/camera-ocmock-refactoring
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
975097d
Refactor permissions logic and remove OCMock from tests
mchudy d8232b1
Introduce protocols and remove OCMock from CameraFocusTests
mchudy a787146
Migrate CameraExposureTests
mchudy 881805a
Initial migration of CameraOrientationTests
mchudy 8b0a57f
Add method channel abstraction
mchudy 6110a3b
Migrate ThreadSafeEventChannelTests
mchudy 688f048
Migrate AvailableCamerasTests
mchudy 22aff03
Migrate more tests and introduce new protocols
mchudy 4bdb8a9
Add new mocks and migrate more tests
mchudy 4be16a2
Remove OCMock dependency
mchudy 124ae95
Reorder files
mchudy eaf80cf
Add protocol for AVCapturePhotoSettings
mchudy 7ac9339
Refactor CameraTestUtils
mchudy 222d30a
Add versioning
mchudy 0088ad6
Revert Info.plist change
mchudy 81143f5
Fix project.pbxproj
mchudy File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,195 +1,196 @@ | ||
## NEXT | ||
|
||
* Updates minimum supported SDK version to Flutter 3.22/Dart 3.4. | ||
- Updates minimum supported SDK version to Flutter 3.22/Dart 3.4. | ||
- Removes OCMock from tests. | ||
|
||
## 0.9.17+5 | ||
|
||
* Adds ability to use any supported FPS and fixes crash when using unsupported FPS. | ||
- Adds ability to use any supported FPS and fixes crash when using unsupported FPS. | ||
|
||
## 0.9.17+4 | ||
|
||
* Updates Pigeon for non-nullable collection type support. | ||
* Updates minimum supported SDK version to Flutter 3.19/Dart 3.3. | ||
- Updates Pigeon for non-nullable collection type support. | ||
- Updates minimum supported SDK version to Flutter 3.19/Dart 3.3. | ||
|
||
## 0.9.17+3 | ||
|
||
* Fixes deallocation of camera on dispose. | ||
- Fixes deallocation of camera on dispose. | ||
|
||
## 0.9.17+2 | ||
|
||
* Fixes stopVideoRecording waiting indefinitely and lag at start of video. | ||
- Fixes stopVideoRecording waiting indefinitely and lag at start of video. | ||
|
||
## 0.9.17+1 | ||
|
||
* Fixes a crash due to appending sample buffers when readyForMoreMediaData is NO. | ||
- Fixes a crash due to appending sample buffers when readyForMoreMediaData is NO. | ||
|
||
## 0.9.17 | ||
|
||
* Adds Swift Package Manager compatibility. | ||
- Adds Swift Package Manager compatibility. | ||
|
||
## 0.9.16+3 | ||
|
||
* Removes unused `maxVideoDuration` code. | ||
- Removes unused `maxVideoDuration` code. | ||
|
||
## 0.9.16+2 | ||
|
||
* Fixes regression taking a picture in torch mode. | ||
- Fixes regression taking a picture in torch mode. | ||
|
||
## 0.9.16+1 | ||
|
||
* Fixes sample times not being numeric after pause/resume. | ||
- Fixes sample times not being numeric after pause/resume. | ||
|
||
## 0.9.16 | ||
|
||
* Converts Dart-to-host communcation to Pigeon. | ||
* Fixes a race condition in camera disposal. | ||
- Converts Dart-to-host communcation to Pigeon. | ||
- Fixes a race condition in camera disposal. | ||
|
||
## 0.9.15+4 | ||
|
||
* Converts host-to-Dart communcation to Pigeon. | ||
- Converts host-to-Dart communcation to Pigeon. | ||
|
||
## 0.9.15+3 | ||
|
||
* Moves `pigeon` to `dev_dependencies`. | ||
- Moves `pigeon` to `dev_dependencies`. | ||
|
||
## 0.9.15+2 | ||
|
||
* Converts camera query to Pigeon. | ||
- Converts camera query to Pigeon. | ||
|
||
## 0.9.15+1 | ||
|
||
* Simplifies internal handling of method channel responses. | ||
- Simplifies internal handling of method channel responses. | ||
|
||
## 0.9.15 | ||
|
||
* Adds support to control video FPS and bitrate. See `CameraController.withSettings`. | ||
- Adds support to control video FPS and bitrate. See `CameraController.withSettings`. | ||
|
||
## 0.9.14+2 | ||
|
||
* Removes `_ambiguate` methods from example code. | ||
- Removes `_ambiguate` methods from example code. | ||
|
||
## 0.9.14+1 | ||
|
||
* Fixes bug where max resolution preset does not produce highest available resolution on iOS. | ||
- Fixes bug where max resolution preset does not produce highest available resolution on iOS. | ||
|
||
## 0.9.14 | ||
|
||
* Adds support to HEIF format. | ||
- Adds support to HEIF format. | ||
|
||
## 0.9.13+11 | ||
|
||
* Fixes a memory leak of sample buffer when pause and resume the video recording. | ||
* Removes development team from example app. | ||
* Updates minimum iOS version to 12.0 and minimum Flutter version to 3.16.6. | ||
- Fixes a memory leak of sample buffer when pause and resume the video recording. | ||
- Removes development team from example app. | ||
- Updates minimum iOS version to 12.0 and minimum Flutter version to 3.16.6. | ||
|
||
## 0.9.13+10 | ||
|
||
* Adds privacy manifest. | ||
- Adds privacy manifest. | ||
|
||
## 0.9.13+9 | ||
|
||
* Fixes new lint warnings. | ||
- Fixes new lint warnings. | ||
|
||
## 0.9.13+8 | ||
|
||
* Updates example app to use non-deprecated video_player method. | ||
* Updates minimum supported SDK version to Flutter 3.10/Dart 3.0. | ||
- Updates example app to use non-deprecated video_player method. | ||
- Updates minimum supported SDK version to Flutter 3.10/Dart 3.0. | ||
|
||
## 0.9.13+7 | ||
|
||
* Fixes inverted orientation strings. | ||
- Fixes inverted orientation strings. | ||
|
||
## 0.9.13+6 | ||
|
||
* Fixes incorrect use of `NSError` that could cause crashes on launch. | ||
- Fixes incorrect use of `NSError` that could cause crashes on launch. | ||
|
||
## 0.9.13+5 | ||
|
||
* Ignores audio samples until the first video sample arrives. | ||
- Ignores audio samples until the first video sample arrives. | ||
|
||
## 0.9.13+4 | ||
|
||
* Adds pub topics to package metadata. | ||
* Updates minimum supported SDK version to Flutter 3.7/Dart 2.19. | ||
- Adds pub topics to package metadata. | ||
- Updates minimum supported SDK version to Flutter 3.7/Dart 2.19. | ||
|
||
## 0.9.13+3 | ||
|
||
* Migrates `styleFrom` usage in examples off of deprecated `primary` and `onPrimary` parameters. | ||
* Fixes unawaited_futures violations. | ||
- Migrates `styleFrom` usage in examples off of deprecated `primary` and `onPrimary` parameters. | ||
- Fixes unawaited_futures violations. | ||
|
||
## 0.9.13+2 | ||
|
||
* Removes obsolete null checks on non-nullable values. | ||
* Updates minimum supported SDK version to Flutter 3.3/Dart 2.18. | ||
- Removes obsolete null checks on non-nullable values. | ||
- Updates minimum supported SDK version to Flutter 3.3/Dart 2.18. | ||
|
||
## 0.9.13+1 | ||
|
||
* Clarifies explanation of endorsement in README. | ||
- Clarifies explanation of endorsement in README. | ||
|
||
## 0.9.13 | ||
|
||
* Allows camera to be switched while video recording. | ||
* Aligns Dart and Flutter SDK constraints. | ||
- Allows camera to be switched while video recording. | ||
- Aligns Dart and Flutter SDK constraints. | ||
|
||
## 0.9.12 | ||
|
||
* Updates minimum Flutter version to 3.3 and iOS 11. | ||
- Updates minimum Flutter version to 3.3 and iOS 11. | ||
|
||
## 0.9.11+1 | ||
|
||
* Updates links for the merge of flutter/plugins into flutter/packages. | ||
- Updates links for the merge of flutter/plugins into flutter/packages. | ||
|
||
## 0.9.11 | ||
|
||
* Adds back use of Optional type. | ||
* Updates minimum Flutter version to 3.0. | ||
- Adds back use of Optional type. | ||
- Updates minimum Flutter version to 3.0. | ||
|
||
## 0.9.10+2 | ||
|
||
* Updates code for stricter lint checks. | ||
- Updates code for stricter lint checks. | ||
|
||
## 0.9.10+1 | ||
|
||
* Updates code for stricter lint checks. | ||
- Updates code for stricter lint checks. | ||
|
||
## 0.9.10 | ||
|
||
* Remove usage of deprecated quiver Optional type. | ||
- Remove usage of deprecated quiver Optional type. | ||
|
||
## 0.9.9 | ||
|
||
* Implements option to also stream when recording a video. | ||
- Implements option to also stream when recording a video. | ||
|
||
## 0.9.8+6 | ||
|
||
* Updates code for `no_leading_underscores_for_local_identifiers` lint. | ||
* Updates minimum Flutter version to 2.10. | ||
- Updates code for `no_leading_underscores_for_local_identifiers` lint. | ||
- Updates minimum Flutter version to 2.10. | ||
|
||
## 0.9.8+5 | ||
|
||
* Fixes a regression introduced in 0.9.8+4 where the stream handler is not set. | ||
- Fixes a regression introduced in 0.9.8+4 where the stream handler is not set. | ||
|
||
## 0.9.8+4 | ||
|
||
* Fixes a crash due to sending orientation change events when the engine is torn down. | ||
- Fixes a crash due to sending orientation change events when the engine is torn down. | ||
|
||
## 0.9.8+3 | ||
|
||
* Fixes avoid_redundant_argument_values lint warnings and minor typos. | ||
* Ignores missing return warnings in preparation for [upcoming analysis changes](https://github.com/flutter/flutter/issues/105750). | ||
- Fixes avoid_redundant_argument_values lint warnings and minor typos. | ||
- Ignores missing return warnings in preparation for [upcoming analysis changes](https://github.com/flutter/flutter/issues/105750). | ||
|
||
## 0.9.8+2 | ||
|
||
* Fixes exception in registerWith caused by the switch to an in-package method channel. | ||
- Fixes exception in registerWith caused by the switch to an in-package method channel. | ||
|
||
## 0.9.8+1 | ||
|
||
* Ignores deprecation warnings for upcoming styleFrom button API changes. | ||
- Ignores deprecation warnings for upcoming styleFrom button API changes. | ||
|
||
## 0.9.8 | ||
|
||
* Switches to internal method channel implementation. | ||
- Switches to internal method channel implementation. | ||
|
||
## 0.9.7+1 | ||
|
||
* Splits from `camera` as a federated implementation. | ||
- Splits from `camera` as a federated implementation. |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is minimum SDK bump related to OCMock removal?