-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[camera] Remove OCMock from tests #8342
base: main
Are you sure you want to change the base?
[camera] Remove OCMock from tests #8342
Conversation
9d005b6
to
81143f5
Compare
Thank you for your contribution! I'm very excited about this change! It's pretty hard to review a 3000+ LOC PR. Could you break it down to smaller pieces? Smaller PR also helps with resolving potential code conflict since this plugin is being actively developed by the community. |
@@ -1,195 +1,196 @@ | |||
## NEXT | |||
|
|||
* Updates minimum supported SDK version to Flutter 3.22/Dart 3.4. | |||
- Updates minimum supported SDK version to Flutter 3.22/Dart 3.4. | |||
- Removes OCMock from tests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is minimum SDK bump related to OCMock removal?
This PR removes dependency on OCMock in unit tests and serves as a first step for full Swift migration. flutter/flutter#119109
AVFoundation
class with default implementations and mocksAVFoundation
classes with new protocolsFLTCamConfiguration
for easier usage in tests as new protocols increased the number of dependencies required to initialize a newFLTCam
instanceFLTCam
to minimize the risk of introducing regressions. SplittingFLTCam
into smaller classes will happen in further PRs.AVFoundation
methods require pointers to raw objects thus I'm sometimes keeping the underlying instance exposed which is not very elegant, I'm open to any suggestions on to how we can clean this up.I took some inspiration from how it was done in case of the
in_app_purchase
package flutter/flutter#116383Pre-launch Checklist
dart format
.)[shared_preferences]
pubspec.yaml
with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.md
to add a description of the change, following repository CHANGELOG style, or this PR is exempt from CHANGELOG changes.///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.