Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor SOLiD code into new module under 'platforms' #221

Open
wants to merge 12 commits into
base: devel
Choose a base branch
from

Conversation

pjbriggs
Copy link
Member

@pjbriggs pjbriggs commented Dec 5, 2024

Moves and reimplements the code for handling SOLiD sequencing data from bcftbx.SolidData into a new module in platforms.solid.data, and from bcftbx.Experiment into platforms.solid.experiment.

The refactoring includes removing the leading Solid from class names (e.g. SolidSample becomes just Sample etc) and changing some method names from camel-case (e.g. getLibraries) to more conventional underscore-separated formats (e.g. get_libraries). (NB SolidRun has been renamed to RunDir.)

The SolidData module has been reimplemented as wrappers around the classes in platforms.solid.data (and the Experiment module as wrappers for platforms.solid.experiment), with the old class and method names still supported for backwards compatibility. It is anticipated that if this PR is merged then the legacy SolidData.py and Experiment modules will be removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant