feat: new Zinnia API stationId
#520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
.gitignore
Outdated
| @@ -1 +1,2 @@ | |||
| /target | |||
| *.DS_Store | |||
There was a problem hiding this comment.
Suggested change
| *.DS_Store | |
| *.DS_Store | |
| @@ -178,6 +179,7 @@ mod tests { | |||
| cache_root: temp.join("cache").to_string_lossy().into(), | |||
| state_root: temp.join("state").to_string_lossy().into(), | |||
| wallet_address: "f1test".to_string(), | |||
| station_id: "zinnia-dev".to_string(), | |||
There was a problem hiding this comment.
I think that only passing through the environment variable "station_id" isn't ideal, as Zinnia ideally doesn't know anything about Station. Instead there should be a way to pass any key value pair into the module context. I believe that implementing this is out of scope for this PR, so just noting here that I would like to improve this in the future.
bajtos
requested changes
Apr 15, 2024
|
@PatrickNercessian also please fix the build failures:
|
PatrickNercessian
changed the title
bajtos
changed the title
stationId
|
https://github.com/filecoin-station/zinnia/actions/runs/8692944647/job/23914200368?pr=520 To speed up the process, I changed the PR from "draft" to a regular one, updated the PR title and will proceed to land & publish this change. |
bajtos
approved these changes
Apr 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DRAFT: DO NOT MERGE
Links:
space-meridian/roadmap#96