Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Get station_id from Zinnia env and add to measurements submission #59

Closed

Conversation

PatrickNercessian
Copy link
Contributor

@PatrickNercessian PatrickNercessian commented Apr 12, 2024

@juliangruber juliangruber marked this pull request as draft April 15, 2024 07:04
@juliangruber
Copy link
Member

Depends on filecoin-station/zinnia#520

Copy link
Member

@bajtos bajtos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code change LGTM 👌🏻

You will need to update the CI workflow to fetch the new Zinnia version. (After we land your Zinnia PR and publish a new version.)

- run: curl -L https://github.com/filecoin-station/zinnia/releases/download/v0.16.0/zinnia-linux-x64.tar.gz | tar -xz

@PatrickNercessian PatrickNercessian changed the title Get station_id from Zinnia env and add to measurements submission Feat: Get station_id from Zinnia env and add to measurements submission Apr 15, 2024
@PatrickNercessian PatrickNercessian marked this pull request as ready for review April 17, 2024 22:11
@bajtos bajtos removed the blocked label Apr 18, 2024
Copy link
Member

@bajtos bajtos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@bajtos
Copy link
Member

bajtos commented Apr 18, 2024

Landed via #60. I couldn't figure out why GitHub refused to run the CI workflow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ done
Development

Successfully merging this pull request may close these issues.

3 participants