fix(typescript): avoid parsing empty messageTerminators in JSON stream case. #5471
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Our
Stream.ts
logic currently breaks when the JSON event stream ends in a messageTerminator, leading to an empty string that, when parsed as JSON, results in a parse error.This fix 1) better checks for complex messageTerminator patterns and 2) performs a better check for empty lines.
Changes Made
Stream.ts
with two changes to parsing logic.Testing