Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(go): handle missing delimiter case during stream parse method. #5492

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

fix(go): handle missing delimiter case during stream parse method. #5492

wants to merge 9 commits into from

Conversation

eyw520
Copy link
Member

@eyw520 eyw520 commented Dec 27, 2024

Description

Fixes an issue where stream delimiter length was included while reading stream data, leading to a bufio.ErrAdvanceTooFar error.

Changes Made

  • modify parse method.

Testing

  • Unit tests added/updated
  • Manual testing completed

@eyw520 eyw520 requested a review from amckinney December 27, 2024 02:18
@eyw520 eyw520 requested a review from dsinghvi as a code owner December 27, 2024 02:18
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 27, 2024 •
edited
Loading

🌿 Preview your docs: https://fern-preview-181a96e7-175c-4e35-954d-3f8d3eb4090e.docs.buildwithfern.com/learn

amckinney
amckinney approved these changes Dec 27, 2024
View reviewed changes
Copy link
Member

@amckinney amckinney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Just a nit on variable naming.

generators/go/internal/generator/sdk/core/stream.go Outdated Show resolved Hide resolved
generators/go/internal/generator/sdk/core/stream.go Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amckinney amckinney amckinney approved these changes

@dsinghvi dsinghvi Awaiting requested review from dsinghvi dsinghvi is a code owner

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eyw520 @amckinney