This repository has been archived by the owner on Nov 21, 2023. It is now read-only.
Support export of CollectAndDistributeFpnRpnProposalsOp #334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orionr
commented
Apr 2, 2018
orionr
commented
- This is somewhat of an RFP, but hopefully we'll land some variation in the near future.
newstzpz
reviewed
Apr 3, 2018
tools/convert_pkl_to_pb.py
Outdated
| ) | ||
| net.external_input.extend([ext_input]) | ||
| return [gen_proposals_op] | ||
| @op_filter() |
There was a problem hiding this comment.
@op_filter(type='Python')?
There was a problem hiding this comment.
@newstzpz L218 is here to replace it if I am not mistaking
There was a problem hiding this comment.
I don't really have much preference between a direct check below and a type='Python' check in the decorator. Any preference across the team?
orionr
force-pushed
the
add-export-support-fpn
branch
from
8c49e43 to
874b2a6
Compare
|
Okay - this should be able to land when ready. I rebased to latest and ran to confirm existing models work. The FPN model as follows fails on test, but likely due to GenerateProposals needing some adjustment. For the record, I ran cc @yinghai who will be working on FPN support. |
|
okay the file need a solution it better we join hand together and fix it
…On Wed, Apr 4, 2018 at 3:25 PM, Orion Reblitz-Richardson < ***@***.***> wrote:
Okay - this should be able to land when ready. I rebased to latest and ran
wget https://s3-us-west-2.amazonaws.com/detectron/35857197/12_2017_baselines/e2e_faster_rcnn_R-50-C4_1x.yaml.01_33_49.iAX0mXvW/output/train/coco_2014_train%3Acoco_2014_valminusminival/generalized_rcnn/model_final.pkl -O models/e2e_faster_rcnn_R-50-C4_1x_35857197.pkl
python tools/convert_pkl_to_pb.py --use_nnpack 0 --net_name detectron_e2e_faster_rcnn_R-50-C4_1x_35857197 --cfg configs/12_2017_baselines/e2e_faster_rcnn_R-50-C4_1x.yaml --out_dir models/pb_output/e2e_faster_rcnn_R-50-C4_1x/ --test_img demo/16004479832_a748d55f21_k.jpg TEST.WEIGHTS models/e2e_faster_rcnn_R-50-C4_1x_35857197.pkl
to confirm existing models work.
The FPN model as follows fails on test, but likely due to
GenerateProposals needing some adjustment. For the record, I ran
wget https://s3-us-west-2.amazonaws.com/detectron/35857345/12_2017_baselines/e2e_faster_rcnn_R-50-FPN_1x.yaml.01_36_30.cUF7QR7I/output/train/coco_2014_train%3Acoco_2014_valminusminival/generalized_rcnn/model_final.pkl -O models/e2e_faster_rcnn_R-50-FPN_1x_35857345.pkl
python tools/convert_pkl_to_pb.py --use_nnpack 0 --net_name detectron_e2e_faster_rcnn_R-50-FPN_1x_35857345 --cfg configs/12_2017_baselines/e2e_faster_rcnn_R-50-FPN_1x.yaml --out_dir models/pb_output/e2e_faster_rcnn_R-50-FPN_1x/ --test_img demo/16004479832_a748d55f21_k.jpg TEST.WEIGHTS models/e2e_faster_rcnn_R-50-FPN_1x_35857345.pkl
cc @yinghai <https://github.com/yinghai>
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#334 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AjJssDlMBJqRLmAGFrfRP3lmkBzCJw9bks5tlUhogaJpZM4TEKhw>
.
|
|
Thank you for your pull request. We require contributors to sign our Contributor License Agreement, and yours has expired. Before we can review or merge your code, we need you to email [email protected] with your details so we can update your status. |
facebook-github-bot
pushed a commit
that referenced
this pull request
Aug 8, 2018
Summary: Based on orionr's work - [x] Solve [the problem about GenerateProposals](#334 (comment)) - [x] Use the existing [ResizeNearest](https://github.com/caffe2/caffe2/blob/master/caffe2/operators/resize_op.cc#L57) layer instead of UpsampleNearest. ResizeNearest has cpu implementation and neon optimization - [x] Make it work (with pytorch/pytorch#7091) With this PR, FPN is supported in cooperation with pytorch/pytorch#7091. I have verified that it works on `e2e_faster_rcnn_R-50-FPN_1x.yaml` Pull Request resolved: #372 Reviewed By: newstzpz Differential Revision: D9213242 Pulled By: rbgirshick fbshipit-source-id: 8fc7b77e6cbf08adaafd760505dd760df59bfd79
|
@rbgirshick As #372 is in I think this one could be closed. |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
xzhewei
pushed a commit
to xzhewei/Detectron
that referenced
this pull request
Jan 10, 2019
Summary: Based on orionr's work - [x] Solve [the problem about GenerateProposals](facebookresearch#334 (comment)) - [x] Use the existing [ResizeNearest](https://github.com/caffe2/caffe2/blob/master/caffe2/operators/resize_op.cc#L57) layer instead of UpsampleNearest. ResizeNearest has cpu implementation and neon optimization - [x] Make it work (with pytorch/pytorch#7091) With this PR, FPN is supported in cooperation with pytorch/pytorch#7091. I have verified that it works on `e2e_faster_rcnn_R-50-FPN_1x.yaml` Pull Request resolved: facebookresearch#372 Reviewed By: newstzpz Differential Revision: D9213242 Pulled By: rbgirshick fbshipit-source-id: 8fc7b77e6cbf08adaafd760505dd760df59bfd79
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.