Skip to content
This repository has been archived by the owner on Nov 21, 2023. It is now read-only.

Wrong argument number in convert_pkl_to_pb.py #337

Closed
daquexian opened this issue Apr 3, 2018 · 4 comments
Closed

Wrong argument number in convert_pkl_to_pb.py #337

daquexian opened this issue Apr 3, 2018 · 4 comments
Labels

Comments

@daquexian
Copy link
Contributor

daquexian commented Apr 3, 2018

Expected results

convert_pkl_to_pb.py runs successfully

Actual results

TypeError: initialize_model_from_cfg() takes at least 1 argument (0 given)

Obviously this function takes at least 1 argument, but actually no argument is given

What makes me more confused is that even though convert_pkl_to_pb.py can't run, there is a PR(#334 ) about this file(which don't fix this bug). So is the PR proposed without even trying to run it once? :|

System information

  • Operating system: cuda9.0 detectron docker
@ir413
Copy link
Contributor

ir413 commented Apr 3, 2018

Hi @daquexian, thanks for reporting. We will fix this shortly.

@daquexian
Copy link
Contributor Author

daquexian commented Apr 3, 2018

@ir413 Thanks for your early reply! I have submitted a PR which fixed this issue and converted a model correctly. You might want to merge it if there is nothing wrong with it. :)

@ir413
Copy link
Contributor

ir413 commented Apr 4, 2018

Thanks for the PR @daquexian. I submitted a PR internally when I wrote my initial comment above but it took some time for it to get published on github (1d67750). Sorry for the inconvenience.

@ir413 ir413 closed this as completed Apr 4, 2018
@daquexian
Copy link
Contributor Author

@ir413 All right :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants