Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #1 addError is undefined when added as middleware to Elysia 0.8.9 #3

Merged
merged 3 commits into from
Feb 6, 2024

Conversation

KilianB
Copy link
Contributor

@KilianB KilianB commented Feb 1, 2024

The diff looks a bit worse than it should be. It is a 2 line change but indentation changes as the plugin is initialized with a new object as proposed here: https://elysiajs.com/essential/plugin.html#functional-callback

This has the added advantage that typescript type error are resolved when using the newest elysia version.

Copy link
Owner

@eelkevdbos eelkevdbos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@eelkevdbos
Copy link
Owner

@KilianB, it seems that your branch does not pass the tests because the package.json (and lockfile) are not updated to the latest Elysia version (^0.8.15). Can you perhaps update this? That seems to get the test suite green.

@KilianB
Copy link
Contributor Author

KilianB commented Feb 6, 2024

@KilianB, it seems that your branch does not pass the tests because the package.json (and lockfile) are not updated to the latest Elysia version (^0.8.15). Can you perhaps update this? That seems to get the test suite green.

@eelkevdbos done

@eelkevdbos eelkevdbos merged commit 119f332 into eelkevdbos:main Feb 6, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants