Fix addError is undefined issues on Elysia 0.8.9
#2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nathankleyn
commented
Jan 20, 2024
Upgrade Elysia to `0.8.9` (latest): ``` $ bun pm ls node_modules (19) ├── [email protected] ├── [email protected] ├── [email protected] ├── [email protected] └── [email protected] ``` Then fix the breaking change to rename `addError` to `error`. After doing this there appears to be a bug where the custom error code is no longer set when the `onError` handler is called (`code` is always `undefined`); to work around this, use `instanceof` instead to check for the custom error code.
|
@nathankleyn, thank you for your contribution! I'd like to go with the version supplied by @KilianB because it keeps the custom error code specification in tact. So I'm closing this for now, but again, much appreciated. |
|
That's perfect, thanks so much @eelkevdbos — so appreciate this being fixed by both yourself and @KilianB! 👏 🙇♂️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade Elysia to
0.8.9(latest):Then fix the breaking change to rename
addErrortoerror. After doing this there appears to be a bug where the custom error code is no longer set when theonErrorhandler is called (codeis alwaysundefined); to work around this, useinstanceofinstead to check for the custom error code.This fixes #1.