Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove outdated link to cross build wiki from product editor #763

Merged
merged 1 commit into from
Sep 25, 2023

Conversation

vogella
Copy link
Contributor

@vogella vogella commented Sep 22, 2023

The content of the wiki is outdated and adding such information to a UI for maintaining the data feels misplaced.

Fixes #758

@github-actions
Copy link

github-actions bot commented Sep 22, 2023

Test Results

     273 files  +     91       273 suites  +91   1h 0m 54s ⏱️ + 23m 32s
  3 340 tests ±       0    3 308 ✔️  -        2  30 💤 ±  0  0 ±0  2 🔥 +2 
10 317 runs  +3 439  10 225 ✔️ +3 407  90 💤 +30  0 ±0  2 🔥 +2 

For more details on these errors, see this check.

Results for commit a2d645e. ± Comparison against base commit d6cee01.

♻️ This comment has been updated with latest results.

@HannesWell
Copy link
Member

Sounds good, but please also remove the handling of the link in the org.eclipse.pde.internal.ui.editor.product.OverviewPage.linkActivated().

@vogella
Copy link
Contributor Author

vogella commented Sep 25, 2023

Sounds good, but please also remove the handling of the link in the org.eclipse.pde.internal.ui.editor.product.OverviewPage.linkActivated().

Thanks, done now

@vogella
Copy link
Contributor Author

vogella commented Sep 25, 2023

AFAIK I have not seen the build error in the log before. Version seems to have been increased for this plug-in already, so it is not one of these nice API baseline errors. @HannesWell do you know that is wrong here?

@HannesWell
Copy link
Member

have not seen the build error in the log before. Version seems to have been increased for this plug-in already, so it is not one of these nice API baseline errors. @HannesWell do you know that is wrong here?

The log a bit further above tells it:

16:51:29  [INFO] --- tycho-apitools:4.0.2:verify (verify) @ org.eclipse.pde.ui ---
16:51:29  [INFO] Resolve API baseline for org.eclipse.pde:org.eclipse.pde.ui:eclipse-plugin:3.14.200-SNAPSHOT
16:51:35  [INFO] Resolve API tools runtime from MavenRepositoryLocation [location=https://download.eclipse.org/eclipse/updates/4.30-I-builds/]...
16:52:32  Some blocking (most likely link/compilation) errors are present:
16:52:32  [FATAL] File OverviewPage.java at line 119: The method openBrowser(String) from the type OverviewPage is never used locally (location: /home/jenkins/agent/workspace/eclipse.pde_PR-763/ui/org.eclipse.pde.ui/src/org/eclipse/pde/internal/ui/editor/product/OverviewPage.java)
16:52:32  Some blocking (most likely link/compilation) errors are present ^^^

Although this is actually not directly related to an API problem it is right that the openBrowser() method should be removed.

I updated the PR accordingly and also adjusted the wording of the footer to Fixes https://github.com/eclipse-pde/eclipse.pde/issues/758 to auto-link this PR with that issue.

The content of the wiki is outdated and adding such information to a UI
for maintaining the data feels misplaced.

Fixes #758
@HannesWell HannesWell merged commit 3dd8aa8 into master Sep 25, 2023
12 of 14 checks passed
@HannesWell HannesWell deleted the remove-wiki-link branch September 25, 2023 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove outdated link to wiki from product editor
2 participants