Skip to content

Commit

Permalink
Remove outdated link to cross build wiki from product editor
Browse files Browse the repository at this point in the history
The content of the wiki is outdated and adding such information to a UI
for maintaining the data feels misplaced.

Fixes #758
  • Loading branch information
vogella authored and HannesWell committed Sep 25, 2023
1 parent d6cee01 commit 3dd8aa8
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 30 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,6 @@
*******************************************************************************/
package org.eclipse.pde.internal.ui.editor.product;

import java.net.MalformedURLException;
import java.net.URL;

import org.eclipse.pde.internal.core.iproduct.IProduct;
import org.eclipse.pde.internal.ui.IHelpContextIds;
import org.eclipse.pde.internal.ui.PDELabelProvider;
Expand All @@ -28,10 +25,7 @@
import org.eclipse.pde.internal.ui.editor.LaunchShortcutOverviewPage;
import org.eclipse.pde.internal.ui.editor.PDELauncherFormEditor;
import org.eclipse.swt.widgets.Composite;
import org.eclipse.ui.PartInitException;
import org.eclipse.ui.PlatformUI;
import org.eclipse.ui.browser.IWebBrowser;
import org.eclipse.ui.browser.IWorkbenchBrowserSupport;
import org.eclipse.ui.forms.IManagedForm;
import org.eclipse.ui.forms.events.HyperlinkEvent;
import org.eclipse.ui.forms.widgets.FormText;
Expand Down Expand Up @@ -110,36 +104,16 @@ public void linkActivated(HyperlinkEvent e) {
IProduct product = ((ProductLauncherFormPageHelper) getLauncherHelper()).getProduct();
getEditor().setActivePage(DependenciesPage.TYPE_2_ID.get(product.getType()));
break;
case "multi-platform-wiki": //$NON-NLS-1$
openBrowser("https://wiki.eclipse.org/Building#Cross-platform_build"); //$NON-NLS-1$
break;
default:
super.linkActivated(e);
break;
}
}

private static void openBrowser(String url) {
// Create the browser
IWorkbenchBrowserSupport support = PlatformUI.getWorkbench().getBrowserSupport();
IWebBrowser browser;
try {
browser = support.createBrowser(null);
} catch (PartInitException e) {
PDEPlugin.log(e);
return;
}

try {
browser.openURL(new URL(url));
} catch (PartInitException | MalformedURLException e) {
PDEPlugin.log(e);
}
}

protected ILauncherFormPageHelper getLauncherHelper() {
if (fLauncherHelper == null)
if (fLauncherHelper == null) {
fLauncherHelper = new ProductLauncherFormPageHelper(getPDELauncherEditor());
}
return fLauncherHelper;
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2107,8 +2107,7 @@ Product_FeatureSection_autoIncludeRequirements=Include required Features and Plu
ProductFileWizadPage_title=Create a new product configuration and initialize its content.
ProductFileWizadPage_basic=&Create a configuration file with basic settings
Product_overview_exporting = <form>\
<p>Use the <a href="action.export">Eclipse Product export wizard</a> to package and export the product defined in this configuration.</p><p></p>\
<p>To export the product to multiple platforms see the <a href="multi-platform-wiki">Cross Platform Wiki Page</a>.</p>\
<p>Use the <a href="action.export">Eclipse Product export wizard</a> to package and export the product defined in this configuration.</p>\
</form>
GeneralInfoSection_desc=This section describes general information about the product.
ProductInfoSection_desc=This section describes the launching product extension identifier and application.
Expand Down

0 comments on commit 3dd8aa8

Please sign in to comment.