-
Notifications
You must be signed in to change notification settings - Fork 203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enhance EasyBlock
class to allow passing in logfile
#4707
enhance EasyBlock
class to allow passing in logfile
#4707
Conversation
7119d9e
to
a1c36f1
Compare
a1c36f1
to
e3cb8f0
Compare
In the case an EasyBlock creates another instance of an EasyBlock (for example when dealing with Bundles), each instance will create new log file, which may stay open and cause issues down the line. To prevent this, add an option to the EasyBlock constructor to pass a logfile from another EasyBlock. Signed-off-by: Jan André Reuter <[email protected]>
e3cb8f0
to
1d18c7e
Compare
@boegel If you find any time for a short review, can you look over this PR? |
EasyBlock
class to allow passing in logfile
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Looks great to me, I didn't see anything that would need to be changed... |
In the case an EasyBlock creates another instance of an EasyBlock (for example when dealing with Bundles), each instance will create new log file, which may stay open and cause issues down the line. To prevent this, add an option to the EasyBlock constructor to disable logging to files.
Marked as draft until verified with QuantumESPRESSO and Bundle changes in respective PRs. I want to really make sure that all issues are resolved first.
Related: easybuilders/easybuild-easyconfigs#21841, easybuilders/easybuild-easyblocks#3505