-
Notifications
You must be signed in to change notification settings - Fork 283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
let internal easyblock not create a log file in QuantumESPRESSO easyblock #3505
let internal easyblock not create a log file in QuantumESPRESSO easyblock #3505
Conversation
Logs of normal build seem to be still working. My idea for a more robust fix would be:
I will take a look and update this PR accordingly. |
f0ffe6d
to
579e6bd
Compare
CI fails as expected, due to changes in framework. |
Found issues with the implementation in framework. Changed the implementation and will try again. |
579e6bd
to
3736885
Compare
New changes in framework work together with this PR. The EasyConfig test suite fails due to GROMACS, but this is not related to this PR. Will leave this as Draft until the Bundle PR, initially introduced in #3472, is also ready and I'm sure that everything works for sure. |
This fixes the increased memory usage when running the EasyConfig test suite as log files would stay open. Signed-off-by: Jan André Reuter <[email protected]>
3736885
to
2e61705
Compare
Test report by @Thyre Overview of tested easyconfigs (in order)
Build succeeded for 7 out of 7 (1 easyconfigs in total) |
@boegelbot please test @ jsc-zen3 |
@Thyre: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de PR test command '
Test results coming soon (I hope)... - notification for comment with ID 2516322942 processed Message to humans: this is just bookkeeping information for me, |
Test report by @boegelbot Overview of tested easyconfigs (in order)
Build succeeded for 1 out of 1 (1 easyconfigs in total) |
CI tests re-triggered now that easybuilders/easybuild-framework#4707 is merged... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Test report by @boegel Overview of tested easyconfigs (in order)
Build succeeded for 1 out of 1 (1 easyconfigs in total) |
This fixes the increased disk usage when running the EasyConfig test suite as log files would stay open.
See easybuilders/easybuild-easyconfigs#21841 for more information.
Requires:
EasyBlock
class to allow passing inlogfile
easybuild-framework#4707Fixes:
Old Notes: