Implement tab bar remote message #14721
Annotations
10 errors, 12 warnings, and 7 notices
Run integration tests:
IntegrationTests/App/DeallocationTests.swift#L142
testWhenLastTabClosed_windowIsDeallocated, Asynchronous wait failed: Exceeded timeout of 5 seconds, with unfulfilled expectations: "<DuckDuckGo_Privacy_Browser.TabBarViewController: 0x403f73d40> should deallocate", "<DuckDuckGo_Privacy_Browser.TabCollectionViewModel: 0x6000031dd3f0> should deallocate", "<DuckDuckGo_Privacy_Browser.TabBarViewController: 0x168de99d0> should deallocate", "<DuckDuckGo_Privacy_Browser.TabCollectionViewModel: 0x600007275c30> should deallocate", "<DuckDuckGo_Privacy_Browser.TabBarViewController: 0x40cf72fc0> should deallocate", "<DuckDuckGo_Privacy_Browser.TabCollectionViewModel: 0x6000031d1d90> should deallocate".
|
Run integration tests:
IntegrationTests/App/DeallocationTests.swift#L142
testWhenLastTabClosed_windowIsDeallocated, Asynchronous wait failed: Exceeded timeout of 5 seconds, with unfulfilled expectations: "<DuckDuckGo_Privacy_Browser.TabBarViewController: 0x168dcbf20> should deallocate", "<DuckDuckGo_Privacy_Browser.TabCollectionViewModel: 0x6000031a8210> should deallocate", "<DuckDuckGo_Privacy_Browser.TabBarViewController: 0x17054c830> should deallocate", "<DuckDuckGo_Privacy_Browser.TabCollectionViewModel: 0x60000726c840> should deallocate", "<DuckDuckGo_Privacy_Browser.TabBarViewController: 0x40a79f5c0> should deallocate", "<DuckDuckGo_Privacy_Browser.TabCollectionViewModel: 0x600003124bb0> should deallocate".
|
Run integration tests:
IntegrationTests/App/DeallocationTests.swift#L142
testWhenLastTabClosed_windowIsDeallocated, Asynchronous wait failed: Exceeded timeout of 5 seconds, with unfulfilled expectations: "<DuckDuckGo_Privacy_Browser.TabBarViewController: 0x162a0e490> should deallocate", "<DuckDuckGo_Privacy_Browser.TabCollectionViewModel: 0x6000032600b0> should deallocate", "<DuckDuckGo_Privacy_Browser.TabBarViewController: 0x113fc5a00> should deallocate", "<DuckDuckGo_Privacy_Browser.TabCollectionViewModel: 0x600007260420> should deallocate", "<DuckDuckGo_Privacy_Browser.TabBarViewController: 0x17057da80> should deallocate", "<DuckDuckGo_Privacy_Browser.TabCollectionViewModel: 0x60000727cb00> should deallocate".
|
Run integration tests:
IntegrationTests/App/DeallocationTests.swift#L99
testWindowsDeallocation, Asynchronous wait failed: Exceeded timeout of 5 seconds, with unfulfilled expectations: "<DuckDuckGo_Privacy_Browser.TabBarViewController: 0x123edf910> should deallocate", "<DuckDuckGo_Privacy_Browser.TabCollectionViewModel: 0x60000313d8c0> should deallocate", "<DuckDuckGo_Privacy_Browser.Tab: 0x1237f7850> should deallocate", "<DuckDuckGo_WebView: 0x166fb21d0> should deallocate", "<DuckDuckGo_Privacy_Browser.Tab: 0x168d47210> should deallocate", "<DuckDuckGo_WebView: 0x40daf4dc0> should deallocate", "<DuckDuckGo_Privacy_Browser.TabBarViewController: 0x127e44be0> should deallocate", "<DuckDuckGo_Privacy_Browser.TabCollectionViewModel: 0x600007270dc0> should deallocate", "<DuckDuckGo_Privacy_Browser.Tab: 0x41a2c2d30> should deallocate", "<DuckDuckGo_WebView: 0x41a2e32a0> should deallocate", "<DuckDuckGo_Privacy_Browser.Tab: 0x4077e1f90> should deallocate", "<DuckDuckGo_WebView: 0x4077e2a00> should deallocate", "<DuckDuckGo_Privacy_Browser.TabBarViewController: 0x40c491250> should deallocate", "<DuckDuckGo_Privacy_Browser.TabCollectionViewModel: 0x6000072675a0> should deallocate", "<DuckDuckGo_Privacy_Browser.Tab: 0x402fb9a20> should deallocate", "<DuckDuckGo_WebView: 0x402fb9c80> should deallocate", "<DuckDuckGo_Privacy_Browser.Tab: 0x168dd70a0> should deallocate", "<DuckDuckGo_WebView: 0x168d566c0> should deallocate".
|
Run integration tests:
IntegrationTests/App/DeallocationTests.swift#L99
testWindowsDeallocation, Asynchronous wait failed: Exceeded timeout of 5 seconds, with unfulfilled expectations: "<DuckDuckGo_Privacy_Browser.TabBarViewController: 0x170580c60> should deallocate", "<DuckDuckGo_Privacy_Browser.TabCollectionViewModel: 0x6000071411e0> should deallocate", "<DuckDuckGo_Privacy_Browser.Tab: 0x125743640> should deallocate", "<DuckDuckGo_WebView: 0x41a225640> should deallocate", "<DuckDuckGo_Privacy_Browser.Tab: 0x1783b2fd0> should deallocate", "<DuckDuckGo_WebView: 0x1783abf60> should deallocate", "<DuckDuckGo_Privacy_Browser.TabBarViewController: 0x40a7f0470> should deallocate", "<DuckDuckGo_Privacy_Browser.TabCollectionViewModel: 0x6000031a3230> should deallocate", "<DuckDuckGo_Privacy_Browser.Tab: 0x12570fc50> should deallocate", "<DuckDuckGo_WebView: 0x40c4b02c0> should deallocate", "<DuckDuckGo_Privacy_Browser.Tab: 0x40c4fc040> should deallocate", "<DuckDuckGo_WebView: 0x40c4fc5c0> should deallocate", "<DuckDuckGo_Privacy_Browser.TabBarViewController: 0x168d5ed70> should deallocate", "<DuckDuckGo_Privacy_Browser.TabCollectionViewModel: 0x60000727bf40> should deallocate", "<DuckDuckGo_Privacy_Browser.Tab: 0x40c4ac070> should deallocate", "<DuckDuckGo_WebView: 0x40c43bbf0> should deallocate", "<DuckDuckGo_Privacy_Browser.Tab: 0x40c4f3b60> should deallocate", "<DuckDuckGo_WebView: 0x40c4f4210> should deallocate".
|
Run integration tests:
IntegrationTests/App/DeallocationTests.swift#L99
testWindowsDeallocation, Asynchronous wait failed: Exceeded timeout of 5 seconds, with unfulfilled expectations: "<DuckDuckGo_Privacy_Browser.TabBarViewController: 0x1237a6c50> should deallocate", "<DuckDuckGo_Privacy_Browser.TabCollectionViewModel: 0x60000726e520> should deallocate", "<DuckDuckGo_Privacy_Browser.Tab: 0x406722c40> should deallocate", "<DuckDuckGo_WebView: 0x4067230e0> should deallocate", "<DuckDuckGo_Privacy_Browser.Tab: 0x1783c2c30> should deallocate", "<DuckDuckGo_WebView: 0x1783c41f0> should deallocate", "<DuckDuckGo_Privacy_Browser.TabBarViewController: 0x1257dc000> should deallocate", "<DuckDuckGo_Privacy_Browser.TabCollectionViewModel: 0x6000071432e0> should deallocate", "<DuckDuckGo_Privacy_Browser.Tab: 0x1783b42a0> should deallocate", "<DuckDuckGo_WebView: 0x1783b4920> should deallocate", "<DuckDuckGo_Privacy_Browser.Tab: 0x40da1b960> should deallocate", "<DuckDuckGo_WebView: 0x40da1c4d0> should deallocate", "<DuckDuckGo_Privacy_Browser.TabBarViewController: 0x168dec610> should deallocate", "<DuckDuckGo_Privacy_Browser.TabCollectionViewModel: 0x600007277180> should deallocate", "<DuckDuckGo_Privacy_Browser.Tab: 0x41a2dd760> should deallocate", "<DuckDuckGo_WebView: 0x40c409060> should deallocate", "<DuckDuckGo_Privacy_Browser.Tab: 0x1783252a0> should deallocate", "<DuckDuckGo_WebView: 0x1783ebb40> should deallocate".
|
Run integration tests:
IntegrationTests/Downloads/DownloadsIntegrationTests.swift#L495
testWhenSaveDialogOpenInBackgroundTabAndWindowIsClosed_downloadIsCancelled, failed - failure(DuckDuckGo_Privacy_Browser.FileDownloadError.failedToCompleteDownloadTask(underlyingError: Optional(Timeout), resumeData: nil, isRetryable: false)) – Download task should‘ve been cancelled
|
Run integration tests:
IntegrationTests/Downloads/DownloadsIntegrationTests.swift#L495
testWhenSaveDialogOpenInBackgroundTabAndWindowIsClosed_downloadIsCancelled, failed - failure(DuckDuckGo_Privacy_Browser.FileDownloadError.failedToCompleteDownloadTask(underlyingError: Optional(Timeout), resumeData: nil, isRetryable: false)) – Download task should‘ve been cancelled
|
Run integration tests:
IntegrationTests/Downloads/DownloadsIntegrationTests.swift#L495
testWhenSaveDialogOpenInBackgroundTabAndWindowIsClosed_downloadIsCancelled, failed - failure(DuckDuckGo_Privacy_Browser.FileDownloadError.failedToCompleteDownloadTask(underlyingError: Optional(Timeout), resumeData: nil, isRetryable: false)) – Download task should‘ve been cancelled
|
Run integration tests:
IntegrationTests/History/HistoryIntegrationTests.swift#L219
testWhenScriptTrackerLoaded_trackerAddedToHistory, failed: caught error: "Timeout"
|
Upload failed unit tests xcresult
No files were found with the provided path: Non-Sandbox-unittests.xcresult. No artifacts will be uploaded.
|
Run integration tests
sandbox-test-tool isn't code signed but requires entitlements. It is not possible to add entitlements to a binary without signing it. (in target 'sandbox-test-tool' from project 'DuckDuckGo')
|
Build and run unit tests:
LocalPackages/XPCHelper/Sources/XPCHelper/XPCServer.swift#L56
capture of 'newConnection' with non-sendable type 'NSXPCConnection' in a `@Sendable` closure; this is an error in the Swift 6 language mode
|
Build and run unit tests:
LocalPackages/UDSHelper/Sources/UDSHelper/UDSServer.swift#L25
extension declares a conformance of imported type 'NWConnection' to imported protocols 'Hashable', 'Equatable'; this will not behave correctly if the owners of 'Network' introduce this conformance in the future
|
Build and run unit tests:
LocalPackages/AppKitExtensions/Sources/AppKitExtensions/NSEventExtension.swift#L118
extension declares a conformance of imported type 'Set' to imported protocols 'ExpressibleByStringLiteral', 'ExpressibleByExtendedGraphemeClusterLiteral', 'ExpressibleByUnicodeScalarLiteral'; this will not behave correctly if the owners of 'Swift' introduce this conformance in the future
|
Build and run unit tests:
LocalPackages/NetworkProtectionMac/Sources/NetworkProtectionProxy/FlowManagers/UDPFlowManager.swift#L179
global actor 'UDPFlowActor'-isolated instance method 'hash(into:)' cannot be used to satisfy nonisolated protocol requirement; this is an error in the Swift 6 language mode
|
Build and run unit tests:
LocalPackages/NetworkProtectionMac/Sources/NetworkProtectionProxy/FlowManagers/UDPFlowManager.swift#L173
global actor 'UDPFlowActor'-isolated operator function '==' cannot be used to satisfy nonisolated protocol requirement; this is an error in the Swift 6 language mode
|
Build and run unit tests:
LocalPackages/NetworkProtectionMac/Sources/NetworkProtectionProxy/FlowManagers/UDPFlowManager.swift#L326
global actor 'UDPFlowActor'-isolated instance method 'hash(into:)' cannot be used to satisfy nonisolated protocol requirement; this is an error in the Swift 6 language mode
|
Build and run unit tests:
LocalPackages/NetworkProtectionMac/Sources/NetworkProtectionProxy/FlowManagers/UDPFlowManager.swift#L322
global actor 'UDPFlowActor'-isolated operator function '==' cannot be used to satisfy nonisolated protocol requirement; this is an error in the Swift 6 language mode
|
Build and run unit tests:
LocalPackages/SubscriptionUI/Sources/SubscriptionUI/DebugMenu/DebugPurchaseView.swift#L167
extension declares a conformance of imported type 'String' to imported protocol 'Identifiable'; this will not behave correctly if the owners of 'Swift' introduce this conformance in the future
|
Build and run unit tests:
DuckDuckGo/NetworkProtection/NetworkExtensionTargets/NetworkExtensionTargets/NetworkProtectionTokenStore+SubscriptionTokenKeychainStorage.swift#L25
extension declares a conformance of imported type 'NetworkProtectionKeychainTokenStore' to imported protocol 'SubscriptionTokenStoring'; this will not behave correctly if the owners of 'NetworkProtection' introduce this conformance in the future
|
Build and run unit tests:
DuckDuckGo/NetworkProtection/NetworkExtensionTargets/NetworkExtensionTargets/MacPacketTunnelProvider.swift#L135
'VPNLogger' is deprecated: This goes against Apple logging guidelines and will be removed, please don't use it anymore
|
Run integration tests
Skipped Integration_Tests.MaliciousSiteProtectionIntegrationTests.testFeatureDisabledAndPhishingDetection_tabIsNotMarkedPhishing
|
Run integration tests
Skipped Integration_Tests.MaliciousSiteProtectionIntegrationTests.testPhishingDetected_tabIsMarkedPhishing
|
Run integration tests
Skipped Integration_Tests.MaliciousSiteProtectionIntegrationTests.testPhishingDetectedThenDDGLoaded_tabIsNotMarkedPhishing
|
Run integration tests
Skipped Integration_Tests.MaliciousSiteProtectionIntegrationTests.testPhishingDetectedThenNotDetected_tabIsNotMarkedPhishing
|
Run integration tests
Skipped Integration_Tests.MaliciousSiteProtectionIntegrationTests.testPhishingDetectedViaHTTPRedirectChain_tabIsMarkedPhishing
|
Run integration tests
Skipped Integration_Tests.MaliciousSiteProtectionIntegrationTests.testPhishingDetectedViaJSRedirectChain_tabIsMarkedPhishing
|
Run integration tests
Skipped Integration_Tests.MaliciousSiteProtectionIntegrationTests.testPhishingNotDetected_tabIsNotMarkedPhishing
|
Loading