Implement tab bar remote message #14721
Annotations
10 errors, 12 warnings, and 5 notices
Run integration tests:
IntegrationTests/App/DeallocationTests.swift#L142
testWhenLastTabClosed_windowIsDeallocated, Asynchronous wait failed: Exceeded timeout of 5 seconds, with unfulfilled expectations: "<DuckDuckGo_Privacy_Browser.TabBarViewController: 0x12a9b9ab0> should deallocate", "<DuckDuckGo_Privacy_Browser.TabCollectionViewModel: 0x600002f38840> should deallocate", "<DuckDuckGo_Privacy_Browser.TabBarViewController: 0x4068474c0> should deallocate", "<DuckDuckGo_Privacy_Browser.TabCollectionViewModel: 0x600002f07e90> should deallocate", "<DuckDuckGo_Privacy_Browser.TabBarViewController: 0x179918f10> should deallocate", "<DuckDuckGo_Privacy_Browser.TabCollectionViewModel: 0x600006cb4b00> should deallocate".
|
Run integration tests:
IntegrationTests/App/DeallocationTests.swift#L142
testWhenLastTabClosed_windowIsDeallocated, Asynchronous wait failed: Exceeded timeout of 5 seconds, with unfulfilled expectations: "<DuckDuckGo_Privacy_Browser.TabBarViewController: 0x117fdf670> should deallocate", "<DuckDuckGo_Privacy_Browser.TabCollectionViewModel: 0x600006c8cb00> should deallocate", "<DuckDuckGo_Privacy_Browser.TabBarViewController: 0x170ff7e40> should deallocate", "<DuckDuckGo_Privacy_Browser.TabCollectionViewModel: 0x600006cb1fa0> should deallocate", "<DuckDuckGo_Privacy_Browser.TabBarViewController: 0x406891040> should deallocate", "<DuckDuckGo_Privacy_Browser.TabCollectionViewModel: 0x600002f3acb0> should deallocate".
|
Run integration tests:
IntegrationTests/App/DeallocationTests.swift#L142
testWhenLastTabClosed_windowIsDeallocated, Asynchronous wait failed: Exceeded timeout of 5 seconds, with unfulfilled expectations: "<DuckDuckGo_Privacy_Browser.TabBarViewController: 0x1697e9b40> should deallocate", "<DuckDuckGo_Privacy_Browser.TabCollectionViewModel: 0x600006cbbde0> should deallocate", "<DuckDuckGo_Privacy_Browser.TabBarViewController: 0x12aa863d0> should deallocate", "<DuckDuckGo_Privacy_Browser.TabCollectionViewModel: 0x600006cbae10> should deallocate", "<DuckDuckGo_Privacy_Browser.TabBarViewController: 0x11f758570> should deallocate", "<DuckDuckGo_Privacy_Browser.TabCollectionViewModel: 0x600002f39ce0> should deallocate".
|
Run integration tests:
IntegrationTests/App/DeallocationTests.swift#L99
testWindowsDeallocation, Asynchronous wait failed: Exceeded timeout of 5 seconds, with unfulfilled expectations: "<DuckDuckGo_Privacy_Browser.TabBarViewController: 0x179cd19b0> should deallocate", "<DuckDuckGo_Privacy_Browser.TabCollectionViewModel: 0x600006fb1ef0> should deallocate", "<DuckDuckGo_Privacy_Browser.Tab: 0x128aa3c50> should deallocate", "<DuckDuckGo_WebView: 0x406fe5860> should deallocate", "<DuckDuckGo_Privacy_Browser.Tab: 0x406fb8fd0> should deallocate", "<DuckDuckGo_WebView: 0x406fb9350> should deallocate", "<DuckDuckGo_Privacy_Browser.TabBarViewController: 0x12a90da30> should deallocate", "<DuckDuckGo_Privacy_Browser.TabCollectionViewModel: 0x600002f1d970> should deallocate", "<DuckDuckGo_Privacy_Browser.Tab: 0x406854890> should deallocate", "<DuckDuckGo_WebView: 0x17149d230> should deallocate", "<DuckDuckGo_Privacy_Browser.Tab: 0x406fb1010> should deallocate", "<DuckDuckGo_WebView: 0x406fb1590> should deallocate", "<DuckDuckGo_Privacy_Browser.TabBarViewController: 0x40770e8e0> should deallocate", "<DuckDuckGo_Privacy_Browser.TabCollectionViewModel: 0x600002f2dc30> should deallocate", "<DuckDuckGo_Privacy_Browser.Tab: 0x1714115a0> should deallocate", "<DuckDuckGo_WebView: 0x17140fbc0> should deallocate", "<DuckDuckGo_Privacy_Browser.Tab: 0x4069b57c0> should deallocate", "<DuckDuckGo_WebView: 0x169766420> should deallocate".
|
Run integration tests:
IntegrationTests/App/DeallocationTests.swift#L99
testWindowsDeallocation, Asynchronous wait failed: Exceeded timeout of 5 seconds, with unfulfilled expectations: "<DuckDuckGo_Privacy_Browser.TabBarViewController: 0x1183e4aa0> should deallocate", "<DuckDuckGo_Privacy_Browser.TabCollectionViewModel: 0x600006c88420> should deallocate", "<DuckDuckGo_Privacy_Browser.Tab: 0x128f7c3d0> should deallocate", "<DuckDuckGo_WebView: 0x128f7c630> should deallocate", "<DuckDuckGo_Privacy_Browser.Tab: 0x412571720> should deallocate", "<DuckDuckGo_WebView: 0x412583a70> should deallocate", "<DuckDuckGo_Privacy_Browser.TabBarViewController: 0x4077ef4e0> should deallocate", "<DuckDuckGo_Privacy_Browser.TabCollectionViewModel: 0x600002fb7650> should deallocate", "<DuckDuckGo_Privacy_Browser.Tab: 0x412565390> should deallocate", "<DuckDuckGo_WebView: 0x412565f10> should deallocate", "<DuckDuckGo_Privacy_Browser.Tab: 0x4077ad810> should deallocate", "<DuckDuckGo_WebView: 0x4077041a0> should deallocate", "<DuckDuckGo_Privacy_Browser.TabBarViewController: 0x4069a1250> should deallocate", "<DuckDuckGo_Privacy_Browser.TabCollectionViewModel: 0x600006c8e730> should deallocate", "<DuckDuckGo_Privacy_Browser.Tab: 0x4069aeca0> should deallocate", "<DuckDuckGo_WebView: 0x4069af350> should deallocate", "<DuckDuckGo_Privacy_Browser.Tab: 0x407669470> should deallocate", "<DuckDuckGo_WebView: 0x407669b20> should deallocate".
|
Run integration tests:
IntegrationTests/App/DeallocationTests.swift#L99
testWindowsDeallocation, Asynchronous wait failed: Exceeded timeout of 5 seconds, with unfulfilled expectations: "<DuckDuckGo_Privacy_Browser.TabBarViewController: 0x105333c90> should deallocate", "<DuckDuckGo_Privacy_Browser.TabCollectionViewModel: 0x600006c80000> should deallocate", "<DuckDuckGo_Privacy_Browser.Tab: 0x17996e560> should deallocate", "<DuckDuckGo_WebView: 0x1799ff0f0> should deallocate", "<DuckDuckGo_Privacy_Browser.Tab: 0x4125b6400> should deallocate", "<DuckDuckGo_WebView: 0x4125b69c0> should deallocate", "<DuckDuckGo_Privacy_Browser.TabBarViewController: 0x12aa35330> should deallocate", "<DuckDuckGo_Privacy_Browser.TabCollectionViewModel: 0x600006cb49a0> should deallocate", "<DuckDuckGo_Privacy_Browser.Tab: 0x170fe39e0> should deallocate", "<DuckDuckGo_WebView: 0x170fa56e0> should deallocate", "<DuckDuckGo_Privacy_Browser.Tab: 0x406fb7040> should deallocate", "<DuckDuckGo_WebView: 0x406fb7cc0> should deallocate", "<DuckDuckGo_Privacy_Browser.TabBarViewController: 0x407751010> should deallocate", "<DuckDuckGo_Privacy_Browser.TabCollectionViewModel: 0x600002f22050> should deallocate", "<DuckDuckGo_Privacy_Browser.Tab: 0x170fc90b0> should deallocate", "<DuckDuckGo_WebView: 0x170fc9550> should deallocate", "<DuckDuckGo_Privacy_Browser.Tab: 0x17425fb10> should deallocate", "<DuckDuckGo_WebView: 0x1742603e0> should deallocate".
|
Run integration tests:
IntegrationTests/Downloads/DownloadsIntegrationTests.swift#L495
testWhenSaveDialogOpenInBackgroundTabAndWindowIsClosed_downloadIsCancelled, failed - failure(DuckDuckGo_Privacy_Browser.FileDownloadError.failedToCompleteDownloadTask(underlyingError: Optional(Timeout), resumeData: nil, isRetryable: false)) – Download task should‘ve been cancelled
|
Run integration tests:
IntegrationTests/Downloads/DownloadsIntegrationTests.swift#L495
testWhenSaveDialogOpenInBackgroundTabAndWindowIsClosed_downloadIsCancelled, failed - failure(DuckDuckGo_Privacy_Browser.FileDownloadError.failedToCompleteDownloadTask(underlyingError: Optional(Timeout), resumeData: nil, isRetryable: false)) – Download task should‘ve been cancelled
|
Run integration tests:
IntegrationTests/Downloads/DownloadsIntegrationTests.swift#L495
testWhenSaveDialogOpenInBackgroundTabAndWindowIsClosed_downloadIsCancelled, failed - failure(DuckDuckGo_Privacy_Browser.FileDownloadError.failedToCompleteDownloadTask(underlyingError: Optional(Timeout), resumeData: nil, isRetryable: false)) – Download task should‘ve been cancelled
|
Run integration tests:
IntegrationTests/History/HistoryIntegrationTests.swift#L219
testWhenScriptTrackerLoaded_trackerAddedToHistory, failed: caught error: "Timeout"
|
Run integration tests
sandbox-test-tool isn't code signed but requires entitlements. It is not possible to add entitlements to a binary without signing it. (in target 'sandbox-test-tool' from project 'DuckDuckGo')
|
Upload failed unit tests xcresult
No files were found with the provided path: Sandbox-unittests.xcresult. No artifacts will be uploaded.
|
Build and run unit tests:
LocalPackages/XPCHelper/Sources/XPCHelper/XPCServer.swift#L56
capture of 'newConnection' with non-sendable type 'NSXPCConnection' in a `@Sendable` closure; this is an error in the Swift 6 language mode
|
Build and run unit tests:
LocalPackages/XPCHelper/Sources/XPCHelper/XPCServer.swift#L56
capture of 'newConnection' with non-sendable type 'NSXPCConnection' in a `@Sendable` closure; this is an error in the Swift 6 language mode
|
Build and run unit tests:
LocalPackages/UDSHelper/Sources/UDSHelper/UDSServer.swift#L25
extension declares a conformance of imported type 'NWConnection' to imported protocols 'Hashable', 'Equatable'; this will not behave correctly if the owners of 'Network' introduce this conformance in the future
|
Build and run unit tests:
LocalPackages/UDSHelper/Sources/UDSHelper/UDSServer.swift#L25
extension declares a conformance of imported type 'NWConnection' to imported protocols 'Hashable', 'Equatable'; this will not behave correctly if the owners of 'Network' introduce this conformance in the future
|
Build and run unit tests:
LocalPackages/AppKitExtensions/Sources/AppKitExtensions/NSEventExtension.swift#L118
extension declares a conformance of imported type 'Set' to imported protocols 'ExpressibleByStringLiteral', 'ExpressibleByExtendedGraphemeClusterLiteral', 'ExpressibleByUnicodeScalarLiteral'; this will not behave correctly if the owners of 'Swift' introduce this conformance in the future
|
Build and run unit tests:
LocalPackages/AppKitExtensions/Sources/AppKitExtensions/NSEventExtension.swift#L118
extension declares a conformance of imported type 'Set' to imported protocols 'ExpressibleByStringLiteral', 'ExpressibleByExtendedGraphemeClusterLiteral', 'ExpressibleByUnicodeScalarLiteral'; this will not behave correctly if the owners of 'Swift' introduce this conformance in the future
|
Build and run unit tests:
LocalPackages/NetworkProtectionMac/Sources/NetworkProtectionProxy/FlowManagers/UDPFlowManager.swift#L179
global actor 'UDPFlowActor'-isolated instance method 'hash(into:)' cannot be used to satisfy nonisolated protocol requirement; this is an error in the Swift 6 language mode
|
Build and run unit tests:
LocalPackages/NetworkProtectionMac/Sources/NetworkProtectionProxy/FlowManagers/UDPFlowManager.swift#L173
global actor 'UDPFlowActor'-isolated operator function '==' cannot be used to satisfy nonisolated protocol requirement; this is an error in the Swift 6 language mode
|
Build and run unit tests:
LocalPackages/NetworkProtectionMac/Sources/NetworkProtectionProxy/FlowManagers/UDPFlowManager.swift#L326
global actor 'UDPFlowActor'-isolated instance method 'hash(into:)' cannot be used to satisfy nonisolated protocol requirement; this is an error in the Swift 6 language mode
|
Build and run unit tests:
LocalPackages/NetworkProtectionMac/Sources/NetworkProtectionProxy/FlowManagers/UDPFlowManager.swift#L322
global actor 'UDPFlowActor'-isolated operator function '==' cannot be used to satisfy nonisolated protocol requirement; this is an error in the Swift 6 language mode
|
Run integration tests
Skipped Integration_Tests_App_Store.DownloadsIntegrationTests.testWhenLocalFile_downloadStartsAlwaysDisplayingSavePanel
|
Run integration tests
Skipped Integration_Tests_App_Store.MaliciousSiteProtectionIntegrationTests.testFeatureDisabledAndPhishingDetection_tabIsNotMarkedPhishing
|
Run integration tests
Skipped Integration_Tests_App_Store.MaliciousSiteProtectionIntegrationTests.testPhishingDetected_tabIsMarkedPhishing
|
Run integration tests
Skipped Integration_Tests_App_Store.MaliciousSiteProtectionIntegrationTests.testPhishingDetectedThenDDGLoaded_tabIsNotMarkedPhishing
|
Run integration tests
Skipped Integration_Tests_App_Store.MaliciousSiteProtectionIntegrationTests.testPhishingDetectedViaHTTPRedirectChain_tabIsMarkedPhishing
|
Loading