Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update password_access_token_request.rb to match method parameters in doorkeeper 5.5 #153

Merged
merged 2 commits into from
Sep 3, 2021

Conversation

CircumnavigatingFlatEarther
Copy link
Contributor

doorkeeper 5.5 added a new parameter credentials to Doorkeeper::Oauth::PasswordAccessTokenRequest.initialize resulting in ArgumentError thrown. See this issue.

Once we match the parameters in the methods, we can set skip_client_authentication_for_password_grant to true and it works just fine.

@CircumnavigatingFlatEarther CircumnavigatingFlatEarther marked this pull request as draft June 15, 2021 06:53
Copy link
Member

@nbulaj nbulaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do it in a backward compatible way. Maybe add a check like

if Doorkeeper::VERSION >= ... 
  def initiaize(...)
else
  def initialize(........)
 end

Doorkeeper 5.5.1 added a new parameter to oauth/password_access_token_request.
This results in 5 params getting passed in when Doorkeeper-openid_connect expects 3..4 params.
This update fixes the issue.
@CircumnavigatingFlatEarther CircumnavigatingFlatEarther marked this pull request as ready for review June 16, 2021 06:15
@CircumnavigatingFlatEarther
Copy link
Contributor Author

Travis-ci.org went offline just yesterday and we don't currently have a CI for this gem.

I have tested successfully this branch locally both with Doorkeeper >= 5.5.1 and Doorkeeper 5.5.0.

@jmortlock
Copy link
Contributor

Any updates on getting this merged / released? Seems to be an issue a few people are hitting and it would be nice to be able to update to the latest doorkeeper.

@Antiarchitect
Copy link

Also hit this issue.

@nbulaj nbulaj merged commit 383dd02 into doorkeeper-gem:master Sep 3, 2021
@jhass
Copy link

jhass commented Nov 17, 2021

Can we get a release for this please? :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants