Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing credentials param in password_access_token_request.rb #157

Closed
grun00 opened this issue Jun 18, 2021 · 1 comment
Closed

Missing credentials param in password_access_token_request.rb #157

grun00 opened this issue Jun 18, 2021 · 1 comment

Comments

@grun00
Copy link

grun00 commented Jun 18, 2021

Hey, I noticed that the initializer method in password_access_token_request.rb is missing the credentials param and when I try to request a token I get the following error:

ArgumentError (wrong number of arguments (given 5, expected 3..4)):

Adding the param in the gem seems to fix the issue.

it is like this:

        def initialize(server, client, resource_owner, parameters = {})

it should be like:

        def initialize(server, client, credentials, resource_owner, parameters = {})

Is someone planning on fixing this? I could add a PR.

The commit that created the problem in the doorkeeper gem

@grun00
Copy link
Author

grun00 commented Jun 18, 2021

Someone already opened a PR about it (#153)

@grun00 grun00 closed this as completed Jun 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant