build: INFENG-942: Conditionally bypass build-react job checks #10145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jobs that attempt to skip the entire job if no changes are detected in specific directories. Previously, bumpversion made it so that, by dint of updating various files, the job would not be skipped. Now that we aren't using it, though, certain downstream jobs are failing because React wasn't built. To fix this, I've added a "force" variable to the build-react job, to allow conditionally bypassing the checks if indicated by the caller. This preserves existing behavior, to avoid potentially other unintended consequences of beginning to build React everywhere, but also to avoid running up CircleCI compute bills, as this much extra build time would probably have a material effect on spending.
✅ Deploy Preview for determined-ui canceled.
|
dannysauer
approved these changes
Oct 28, 2024
davidfluck-hpe
changed the title
davidfluck-hpe
added a commit
that referenced
this pull request
Oct 28, 2024
The release job is skipping the React build step because there are two jobs that attempt to skip the entire job if no changes are detected in specific directories. Previously, bumpversion made it so that, by dint of updating various files, the job would not be skipped. Now that we aren't using it, though, certain downstream jobs are failing because React wasn't built. To fix this, I've added a "force" variable to the build-react job, to allow conditionally bypassing the checks if indicated by the caller. This preserves existing behavior, to avoid potentially other unintended consequences of beginning to build React everywhere, but also to avoid running up CircleCI compute bills, as this much extra build time would probably have a material effect on spending.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
INFENG-942
Description
The release job is skipping the React build step because there are two jobs that attempt to skip the entire job if no changes are detected in specific directories. Previously, bumpversion made it so that, by dint of updating various files, the job would not be skipped. Now that we aren't using it, though, certain downstream jobs are failing because React wasn't built.
To fix this, I've added a "force" variable to the build-react job, to allow conditionally bypassing the checks if indicated by the caller. This preserves existing behavior, to avoid potentially other unintended consequences of beginning to build React everywhere, but also to avoid running up CircleCI compute bills, as this much extra build time would probably have a material effect on spending.
Test Plan
Given that it's a CircleCI change and it's release-affecting, I think a visual spot check is okay.
Checklist
docs/release-notes/See Release Note for details.