Skip to content

Commit

Permalink
build: INFENG-942: Conditionally bypass build-react job checks (#10145)
Browse files Browse the repository at this point in the history
The release job is skipping the React build step because there are two
jobs that attempt to skip the entire job if no changes are detected in
specific directories. Previously, bumpversion made it so that, by dint
of updating various files, the job would not be skipped. Now that we
aren't using it, though, certain downstream jobs are failing because
React wasn't built.

To fix this, I've added a "force" variable to the build-react job, to
allow conditionally bypassing the checks if indicated by the
caller. This preserves existing behavior, to avoid potentially other
unintended consequences of beginning to build React everywhere, but also
to avoid running up CircleCI compute bills, as this much extra build
time would probably have a material effect on spending.
  • Loading branch information
davidfluck-hpe committed Oct 28, 2024
1 parent d7f0bbf commit aad58c1
Showing 1 changed file with 10 additions and 2 deletions.
12 changes: 10 additions & 2 deletions .circleci/real_config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2090,14 +2090,21 @@ jobs:
ee:
type: boolean
default: false
force:
type: boolean
default: false
docker:
- image: cimg/node:20.9.0
resource_class: large
steps:
- checkout-with-sm
- add-and-fetch-upstream
- skip-if-only-docs
- skip-if-only-github
- when:
condition:
not: <<parameters.force>>
steps:
- skip-if-only-docs
- skip-if-only-github
- react-get-deps
- run: |
if <<parameters.dev-mode>>; then
Expand Down Expand Up @@ -5517,6 +5524,7 @@ workflows:
- build-proto:
filters: *release-and-rc-filters
- build-react:
force: true
context: determined-production
filters: *release-and-rc-filters
- build-docs:
Expand Down

0 comments on commit aad58c1

Please sign in to comment.