Skip to content

Commit

Permalink
[PROTOCOL][Version Checksum] Remove references to Java-specific Int.M…
Browse files Browse the repository at this point in the history
…axValue and Long.MaxValue (#3961)

<!--
Thanks for sending a pull request!  Here are some tips for you:
1. If this is your first time, please read our contributor guidelines:
https://github.com/delta-io/delta/blob/master/CONTRIBUTING.md
2. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP]
Your PR title ...'.
  3. Be sure to keep the PR description updated to reflect all changes.
  4. Please write your PR title to summarize what this PR proposes.
5. If possible, provide a concise example to reproduce the issue for a
faster review.
6. If applicable, include the corresponding issue number in the PR title
and link it in the body.
-->

#### Which Delta project/connector is this regarding?
<!--
Please add the component selected below to the beginning of the pull
request title
For example: [Spark] Title of my pull request
-->

- [ ] Spark
- [ ] Standalone
- [ ] Flink
- [ ] Kernel
- [X] Other (PROTOCOL)

## Description

<!--
- Describe what this PR changes.
- Describe why we need the change.
 
If this PR resolves an issue be sure to include "Resolves #XXX" to
correctly link and close the issue upon merge.
-->
Fixes a Version Checksum spec changes introduced in
#3777. The last two bin bounds for
Deleted File Count Histogram right now are defined in terms of Java's
Int.MaxValue and Long.MaxValue. This PR makes the spec language
independent by inlining the actual values of these bounds.

## How was this patch tested?

<!--
If tests were added, say they were added here. Please make sure to test
the changes thoroughly including negative and positive cases if
possible.
If the changes were tested in any way other than unit tests, please
clarify how you tested step by step (ideally copy and paste-able, so
that other reviewers can test and check, and descendants can verify in
the future).
If the changes were not tested, please explain why.
-->
N/A

## Does this PR introduce _any_ user-facing changes?

<!--
If yes, please clarify the previous behavior and the change this PR
proposes - provide the console output, description and/or an example to
show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change
compared to the released Delta Lake versions or within the unreleased
branches such as master.
If no, write 'No'.
-->
No
  • Loading branch information
dhruvarya-db authored Dec 12, 2024
1 parent 05cdd3c commit 58f94af
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions PROTOCOL.md
Original file line number Diff line number Diff line change
Expand Up @@ -386,8 +386,8 @@ The histogram bins correspond to the following ranges:
- Bin 5: [10000, 99999] (files with 10,000-99,999 deleted records)
- Bin 6: [100000, 999999] (files with 100,000-999,999 deleted records)
- Bin 7: [1000000, 9999999] (files with 1,000,000-9,999,999 deleted records)
- Bin 8: [10000000, Int.MaxValue - 1] (files with 10,000,000 to Int.MaxValue-1 deleted records)
- Bin 9: [Int.MaxValue, Long.MaxValue] (files with Int.MaxValue or more deleted records)
- Bin 8: [10000000, 2147483646] (files with 10,000,000 to 2147483646 (i.e. Int.MaxValue-1 in Java) deleted records)
- Bin 9: [2147483647, ∞) (files with 2147483647 or more deleted records)

This histogram allows analyzing the distribution of deleted records across files in a Delta table, which can be useful for monitoring and optimizing deletion patterns.

Expand Down

0 comments on commit 58f94af

Please sign in to comment.