Skip to content

Commit

Permalink
[Kernel] Fix incorrect load protocol and metadata time log (#3964)
Browse files Browse the repository at this point in the history
<!--
Thanks for sending a pull request!  Here are some tips for you:
1. If this is your first time, please read our contributor guidelines:
https://github.com/delta-io/delta/blob/master/CONTRIBUTING.md
2. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP]
Your PR title ...'.
  3. Be sure to keep the PR description updated to reflect all changes.
  4. Please write your PR title to summarize what this PR proposes.
5. If possible, provide a concise example to reproduce the issue for a
faster review.
6. If applicable, include the corresponding issue number in the PR title
and link it in the body.
-->

#### Which Delta project/connector is this regarding?
<!--
Please add the component selected below to the beginning of the pull
request title
For example: [Spark] Title of my pull request
-->

- [ ] Spark
- [ ] Standalone
- [ ] Flink
- [X] Kernel
- [ ] Other (fill in here)

## Description
Resolves #3948 
Fixed incorrect load protocol and metadata time log
<!--
- Describe what this PR changes.
- Describe why we need the change.
 
If this PR resolves an issue be sure to include "Resolves #XXX" to
correctly link and close the issue upon merge.
-->

## How was this patch tested?
Unit tests
<!--
If tests were added, say they were added here. Please make sure to test
the changes thoroughly including negative and positive cases if
possible.
If the changes were tested in any way other than unit tests, please
clarify how you tested step by step (ideally copy and paste-able, so
that other reviewers can test and check, and descendants can verify in
the future).
If the changes were not tested, please explain why.
-->

## Does this PR introduce _any_ user-facing changes?
No
<!--
If yes, please clarify the previous behavior and the change this PR
proposes - provide the console output, description and/or an example to
show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change
compared to the released Delta Lake versions or within the unreleased
branches such as master.
If no, write 'No'.
-->
  • Loading branch information
anton-erofeev authored Dec 12, 2024
1 parent 19d89f6 commit 05cdd3c
Showing 1 changed file with 2 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -525,6 +525,8 @@ private SnapshotImpl createSnapshot(LogSegment initSegment, Engine engine) {
.orElse(".");
logger.info("{}: Loading version {} {}", tablePath, initSegment.version, startingFromStr);

long startTimeMillis = System.currentTimeMillis();

LogReplay logReplay =
new LogReplay(
logPath,
Expand All @@ -534,8 +536,6 @@ private SnapshotImpl createSnapshot(LogSegment initSegment, Engine engine) {
initSegment,
Optional.ofNullable(latestSnapshotHint.get()));

long startTimeMillis = System.currentTimeMillis();

assertLogFilesBelongToTable(logPath, initSegment.allLogFilesUnsorted());

final SnapshotImpl snapshot =
Expand Down

0 comments on commit 05cdd3c

Please sign in to comment.