Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

more accurate way for resolving files in node_modules #89

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

anru
Copy link

@anru anru commented Mar 5, 2016

require.resolve always try resolve file from place where it was called. But it's not correct behaviour. We need resolve from original css file.

substack's resolve package allows do it in right way.

@anru anru force-pushed the more-accurate-resolving branch from 7722b62 to c041858 Compare March 7, 2016 22:18
@markdalgleish
Copy link
Member

Looking into this PR now.

@geelen, it seems like file-system-loader.js isn't used outside of tests in this repo (see here), so has no effect on consumers of this package. Was there any particular reason this is in the src directory?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants