Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass correct from arg for resolved files #89

Merged
merged 1 commit into from
Mar 8, 2016

Conversation

anru
Copy link
Contributor

@anru anru commented Mar 7, 2016

Pass correct 'from' parameter to postcss for files which resolved via nodeResolve.sync

Incorrect source path leads to wrong names which postcss-plugin-scope generates for example

@anru
Copy link
Contributor Author

anru commented Mar 7, 2016

Hmm, please don't merge while I'm figuring out with failed tests in css-modules/css-modules-loader-core#89

Pass correct 'from' parameter to postcss for files which resolved via `nodeResolve.sync`

Incorrect source path leads to wrong names which postcss-plugin-scope generates for example
@anru
Copy link
Contributor Author

anru commented Mar 7, 2016

Ok, I fixed tests in css-modules/css-modules-loader-core#89. For getting rid of absolute path I pass relative path which calculates from root.

@joshwnj
Copy link
Member

joshwnj commented Mar 8, 2016

Thanks @anru

joshwnj added a commit that referenced this pull request Mar 8, 2016
Pass correct `from` arg for resolved files
@joshwnj joshwnj merged commit cb519ce into css-modules:master Mar 8, 2016
@joshwnj
Copy link
Member

joshwnj commented Mar 8, 2016

Published v0.21.0

@anru anru deleted the patch-1 branch March 8, 2016 06:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants